Skip to content

Modernize(Emacs27+) define-minor-mode and fix obsolete incf usage#64

Open
zjttyl wants to merge 1 commit into
nschum:masterfrom
zjttyl:Emacs27+
Open

Modernize(Emacs27+) define-minor-mode and fix obsolete incf usage#64
zjttyl wants to merge 1 commit into
nschum:masterfrom
zjttyl:Emacs27+

Conversation

@zjttyl

@zjttyl zjttyl commented Apr 13, 2025

Copy link
Copy Markdown

Modernize define-minor-mode and fix obsolete incf usage

  • Update define-minor-mode for highlight-symbol-mode and
    highlight-symbol-nav-mode to use keyword arguments (:init-value,
    :lighter, :keymap) instead of deprecated positional arguments.
    Eliminates the "Use keywords rather than deprecated positional
    arguments to ‘define-minor-mode’" warning in Emacs 27+.
  • Replace obsolete incf with cl-incf in highlight-symbol-next-color,
    adding (require 'cl-lib) to resolve the "incf is an obsolete alias"
    warning in Emacs 27+. Ensures compatibility with modern Emacs versions.

Fixes issues observed when loading highlight-symbol.el in Emacs 27+.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant