Repository navigation
fix(quic): validate ACK frequency and resize GRO buffers on rebind - #1
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow up Google QUICHE's recent ACK Frequency validation and GRO work with two fixes in the vendored Quinn stack:
Public API signatures, frame encoding, and the default ACK strategy remain unchanged.
Motivation and references
Previously, a peer could request an out-of-range ACK delay, and early-data packets could change ACK behavior before extension negotiation. Separately, replacing a single-segment socket with a 64-segment socket retained the original one-datagram receive capacity, risking GRO truncation.
Related issues: none.
Validation
Added regression coverage for the delay boundaries, legal 1-RTT versus illegal 0-RTT frames, and receive-capacity changes across socket replacements. The PR CI workflow passed all eight jobs for
1f514cc350fa9e37779f022df33320f5d383f0dd: native regression suites on Linux, macOS and Windows, feature profiles, MSRV, HTTP/3, Quinn/UDP, and package verification.An independent executable using
Endpoint::new_with_abstract_socketandrebind_abstractmeasured the buffers supplied toAsyncUdpSocket::poll_recv:These measurements establish receive capacity; they are not throughput or latency benchmarks. Larger buffers are allocated only when a replacement socket requires them and are retained until the endpoint is dropped.
Formatting and
git diff --checkcompleted. Regression suites were validated in CI.