Make publish_status.py post on Slack, new file himlarcli/slack2.py#138
Open
trondham wants to merge 15 commits into
Open
Make publish_status.py post on Slack, new file himlarcli/slack2.py#138trondham wants to merge 15 commits into
trondham wants to merge 15 commits into
Conversation
● Five changes made across five files: ┌───────────────────────────┬────────────────────────────────────────────────────────────────────────────────────────────┐ │ File │ Change │ ├───────────────────────────┼────────────────────────────────────────────────────────────────────────────────────────────┤ │ himlarcli/client.py │ class Client(ABC) instead of Client(object) + __metaclass__; import ABC instead of ABCMeta │ ├───────────────────────────┼────────────────────────────────────────────────────────────────────────────────────────────┤ │ himlarcli/notify.py:89,94 │ .iteritems() → .items() │ ├───────────────────────────┼────────────────────────────────────────────────────────────────────────────────────────────┤ │ himlarcli/mail.py:136,141 │ .iteritems() → .items() │ ├───────────────────────────┼────────────────────────────────────────────────────────────────────────────────────────────┤ │ himlarcli/state.py:154 │ .iteritems() → .items() │ ├───────────────────────────┼────────────────────────────────────────────────────────────────────────────────────────────┤ │ tests/setup_test.py:47 │ .iteritems() → .items() │ └───────────────────────────┴────────────────────────────────────────────────────────────────────────────────────────────┘ The client.py change is the most important — Client will now actually enforce @AbstractMethod on subclasses in Python 3, which was silently broken before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.