feat(hf): query worker cache for downloaded model state when worker is active

[georgi]

Summary

• Adds a scope param (local | worker) to the huggingfaceByType tRPC procedure — when worker, the server queries the Docker worker's cache list via bridge.listCachedModels() and filters with the newly-extracted filterModelsByHfType
• Extracts filterModelsByHfType as a standalone exported function from hf-models.ts (was a private closure inside getModelsByHfType)
• New useWorkerCachedModels hook fetches and normalises the worker's cached model IDs; HuggingFaceModelMenuDialog and RecommendedModelsView use it to show correct downloaded state when a worker is attached
• Wires onSelect through RecommendedModelsView → ModelListItem so recommended models are selectable in the model picker dialog
• Fixes auto-switch-to-downloads firing repeatedly; now fires at most once per dialog open via a ref guard
• Minor: stop click propagation on HF logo link and actions container; add selectable hover styles to ModelListItem

Test plan

• With no worker attached: model dialog shows local HF cache downloaded state as before
• With Docker worker attached: model dialog reflects the worker's cache (models downloaded on worker show as downloaded)
• Clicking a recommended model in the picker selects it
• Auto-switch to downloads view fires once on open, not on every re-render
• HF logo link no longer triggers row click/select

🤖 Generated with Claude Code

[cloudflare-workers-and-pages]

Deploying with    Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status	Name	Latest Commit	Preview URL	Updated (UTC)
✅ Deployment successful! View logs	nodetool-marketing	be5f583	Commit Preview URL Branch Preview URL	Jun 10 2026, 09:04 PM

[georgi]

CI Quality Gate is failing. Please rebase onto current main and fix the build. The worker cache query feature and useWorkerCachedModels hook look well-designed, just needs green CI.

---

Generated by Claude Code

[georgi]

This PR goes far beyond its title — it's closer to "add full worker deployment infrastructure" than "query worker cache for downloaded model state." 153 files with +15K lines is extremely hard to review meaningfully.

Recommendations:

1. Fix CI — Quality Gate is failing
2. Break this into smaller PRs — compute package, deploy package, CLI commands, HF cache query, etc. Each should be independently reviewable and testable.
3. Update the title to reflect the actual scope

The current form is too large for a thorough review. Please split and resubmit.

---

Generated by Claude Code

[georgi]

Needs work before merge:

1. Merge conflicts — mergeable_state is "dirty". Please rebase onto main and resolve conflicts.
2. CI failing — Quality gate (npm run check) failed.
3. Scope too broad — 153 files changed / 57 commits for a model-cache query feature. The branch likely includes unrelated changes or a stale merge from main. Please isolate the HF worker cache feature into a focused PR for reviewable size.

The feature concept (querying worker cache for downloaded model state) is solid, but the PR needs a rebase and scope reduction.

---

Generated by Claude Code

[georgi]

Feature looks well-scoped (HF worker cache querying). Quality Gate is failing though — please rebase on latest main (6 PRs were just merged) and fix CI. Once green, this is ready for a deeper feature review.

---

Generated by Claude Code

[georgi]

The core worker-cache feature is well-designed — tRPC backward compatibility is preserved via .default("local"), filterModelsByHfType extraction is clean, auto-switch ref guard is correct, and backend test coverage is good.

Must fix:

1. CI Quality Gate is failing — lint/typecheck/tests not passing.
2. PR scope is far too large — 1383 files changed with 111k+ insertions, vastly beyond the described HF worker cache feature. This branch has accumulated many unrelated changes and should be rebased/split into focused PRs.
3. useWorkerCachedModels query key — ["worker-cached-models"] has no worker-id qualifier. If the active worker changes, stale cache data persists until the 30s staleTime expires. Include activeWorker?.id in the query key.

Minor:
4. The HF logo link was removed from ModelListItem entirely (replaced with plain div) rather than just stopping propagation — this changes UX (model name no longer links to HF page). Was this intentional?
5. No frontend unit tests for useWorkerCachedModels.

The feature itself is solid once scoped correctly and CI passes.

---

Generated by Claude Code

[georgi]

Needs significant cleanup before merge:

1. Merge conflicts — mergeable_state: dirty
2. Quality Gate failing
3. 153 files / 57 commits — scope creep; the described feature (querying worker cache) shouldn't require this many changes. Consider rebasing, squashing, and splitting unrelated changes.
4. Likely conflicts with feat(model-menu): fold recommended downloads into the model list #3698 (model menu, now merged) — the model picker changes overlap.

Needs: rebase onto current main, resolve conflicts, squash commits, and get CI green.

---

Generated by Claude Code

[georgi]

This PR has 153 files changed (15K+ additions, 10K+ deletions) for what should be a focused HF worker cache feature. The enormous diff suggests the branch accumulated unrelated changes or diverged significantly from main. CI Quality Gate is failing.

Recommend cleaning up the branch to contain only the relevant HF worker cache changes, or splitting into smaller PRs. Rebase needed before merge.

---

Generated by Claude Code

[georgi]

This PR has 153 files and 57 commits with CI failing. 11 days old with no code updates since Jun 11. Likely has merge conflicts. Needs a rebase and CI fix before merge.

---

Generated by Claude Code

[georgi]

Review: Needs splitting

This PR has grown to 153 files, 57 commits, and +15K/-10K lines. The original HF worker cache feature is buried under unrelated changes spanning packages/deploy, packages/compute, packages/models, packages/runtime, packages/websocket, packages/cli, and docs.

Issues:

• Scope creep: The PR mixes a feature (worker cache querying) with infrastructure changes (deploy, compute, docs rewrites). At this scale, effective code review is impractical.
• CI failing: App Tests fail, which is a red flag given the breadth of changes.
• Merge conflicts: Branch has diverged significantly from main.

Recommendation: Split this into smaller, focused PRs:

1. Deploy/docs infrastructure changes
2. Compute package changes
3. The actual HF worker cache feature (with useWorkerCachedModels hook and model picker UI)

Each would be reviewable, testable, and mergeable independently.

---

Generated by Claude Code

[georgi]

The described feature (HF worker cache querying) is reasonable, but this PR is too large to review confidently: 153 files changed, 25k+ lines of churn across 57 commits. The diff exceeds GitHub's rendering limit. Please rebase on main and consider splitting into smaller, independently reviewable PRs.

---

Generated by Claude Code

[georgi]

This PR is too large to review safely: 153 files changed, 57 commits, 15,000+ lines added, 10,500+ lines deleted. The diff exceeds GitHub's 20k-line rendering limit.

While the feature (querying worker cache for downloaded model state) is well-scoped in the description, the actual changeset is far broader — 57 commits accumulated over 15 days suggests unrelated changes got folded in.

Recommendation: Break this into smaller, focused PRs:

1. Extract filterModelsByHfType as a standalone function (pure refactor)
2. Add the scope param to huggingfaceByType tRPC procedure + bridge integration
3. useWorkerCachedModels hook + UI changes in the model picker dialog
4. Fix the auto-switch-to-downloads repeated firing
5. Minor click-propagation / hover style fixes

Each would be reviewable in isolation and mergeable incrementally. As-is, the risk of regression is too high to merge without a very thorough manual review.

---

Generated by Claude Code

[georgi]

This PR has been open since June 10 and CI is red (quality gate failure from June 11). The branch is significantly behind main at this point. Needs a rebase onto current main and CI must pass before this can be merged.

---

Generated by Claude Code

[georgi]

This PR has several issues that need addressing:

1. Merge conflicts — the branch is in a dirty mergeable state and needs a rebase onto main.
2. CI failing — the quality gate is failing.
3. Scope creep — the PR description mentions HF worker cache querying, but the diff touches 153 files with 15,326 additions and 10,546 deletions across 57 commits. This is far beyond the described feature scope and makes review very difficult. Consider splitting this into smaller, focused PRs.

The described feature (querying worker cache for downloaded model state) sounds useful, but the PR needs to be rebased and its scope tightened before it can be reviewed and merged.

---

Generated by Claude Code