fix: max-age=0 and no-cache must be considered "immediately stale"#4624
Open
steunix wants to merge 1 commit intonodejs:mainfrom
Open
fix: max-age=0 and no-cache must be considered "immediately stale"#4624steunix wants to merge 1 commit intonodejs:mainfrom
steunix wants to merge 1 commit intonodejs:mainfrom
Conversation
As per discussion nodejs#4620 (reply in thread) Returning undefined causes the caller to ignore the result from a caching standpoint: max-age=0 and no-cache should return 0 for "immediately stale".
Author
Sorry but I don't know the code base enough to even guess at what level to put a test. |
Uzlopak
reviewed
Oct 16, 2025
Contributor
Uzlopak
left a comment
Uzlopak
left a comment
There was a problem hiding this comment.
Lets see if the tests are still happy fist
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4624 +/- ##
==========================================
- Coverage 92.93% 92.92% -0.01%
==========================================
Files 106 106
Lines 33092 33097 +5
==========================================
+ Hits 30753 30756 +3
- Misses 2339 2341 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
You can put it within the interceptors tests for cache interceptor, attempting to just replicate the behavior described in the issue |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This relates to...
#4620 (reply in thread)
Rationale
When server is responding with a max-age=0 or no-cache, Undici does not cache the response and subsequent requests do not include if-none-match or if-modified-since headers.
Changes
The function determineStaleAt does not take max-age=0 and no-cache into account, returning undefined in both cases: the caller will ignore the response in regard to the cache handling
Features
N/A
Bug Fixes
N/A
Breaking Changes and Deprecations
N/A
Status