Change view type annotation to Uint8Array#63130
Open
debojeetmitra wants to merge 2 commits intonodejs:mainfrom
Open
Change view type annotation to Uint8Array#63130debojeetmitra wants to merge 2 commits intonodejs:mainfrom
debojeetmitra wants to merge 2 commits intonodejs:mainfrom
Conversation
addaleax
approved these changes
May 6, 2026
jasnell
approved these changes
May 6, 2026
github-actions
Bot
removed
the
request-ci
Collaborator
Author
|
Hi, thanks for the reviews! It looks like the CI checks are failing across multiple environments after this change. I suspect the type narrowing to Uint8Array might be affecting some existing expectations. Could you please advise if this change needs to be adjusted or if I should align it differently with the current implementation/tests? Happy to update accordingly. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change narrows the documented return type of
ReadableStreamBYOBRequest.view from ArrayBufferView to Uint8Array,
reflecting the specification update in whatwg/streams#1367.
Closes #62952