src: fix copy-paste bug using wrong argument index for flags in JSUDPWrap#61948
Open
cuiweixie wants to merge 1 commit intonodejs:mainfrom
Open
src: fix copy-paste bug using wrong argument index for flags in JSUDPWrap#61948cuiweixie wants to merge 1 commit intonodejs:mainfrom
cuiweixie wants to merge 1 commit intonodejs:mainfrom
Conversation
addaleax
approved these changes
Feb 23, 2026
Member
addaleax
left a comment
There was a problem hiding this comment.
😬
Do you happen to have a regression test that you could add for this?
Collaborator
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #61948 +/- ##
==========================================
+ Coverage 88.84% 89.77% +0.93%
==========================================
Files 674 674
Lines 204957 205605 +648
Branches 39309 39419 +110
==========================================
+ Hits 182087 184575 +2488
+ Misses 15088 13267 -1821
+ Partials 7782 7763 -19
🚀 New features to boost your workflow:
|
Signed-off-by: Weixie Cui <cuiweixie@gmail.com>
Author
No, i do not have a test.But it is,obviously a right fix, i think. |
addaleax
approved these changes
Feb 23, 2026
Author
|
@addaleax Can you help with the ci failed, It seems is unrelated to this pr. |
Collaborator
cjihrig
approved these changes
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…Wrap