doc: fix typos and grammar in BUILDING.md & onboarding.md #61267

Hardanish-Singh · 2026-01-03T23:33:16Z

Fixed a few grammatical errors and missing words in BUILDING.md to improve readability:

Windows/Tips: Changed "You may need disable" to "You may need to disable"
Windows/Tips: Changed "even you never" to "even if you never"
Windows/ccache: Changed "suggestion missing" to "suggests missing"
Temporal support: Changed "version temporal_rs" to "version of temporal_rs"

nodejs-github-bot · 2026-01-03T23:33:21Z

Review requested:

@nodejs/build
@nodejs/tsc

Hardanish-Singh · 2026-01-03T23:38:46Z

@cjihrig can you please take a look at this PR ?

Xstoudi · 2026-01-04T00:33:56Z

I think you forgot to push a commit as you fixed some typo/grammar but not the those you described.

Hardanish-Singh · 2026-01-04T01:06:28Z

@Xstoudi Thanks for the review! I've pushed the changes, can you please re-review and approve if possible thanks

BUILDING.md

onboarding.md

aduh95

I agree that splitting in two PRs would be nice, though not a blocker

nodejs-github-bot · 2026-01-05T23:40:42Z

Commit Queue failed

- Loading data for nodejs/node/pull/61267
✔  Done loading data for nodejs/node/pull/61267
----------------------------------- PR info ------------------------------------
Title      doc: fix typos and grammar in BUILDING.md & onboarding.md (#61267)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     Hardanish-Singh:doc/fix-building-md-typos -> nodejs:main
Labels     doc, build, author ready
Commits    4
 - doc: fix typos and grammar in BUILDING.md
 - doc: fix typos and grammar in BUILDING.md
 - doc: fix typos and grammar in BUILDING.md
 - doc: fix typos and grammar in BUILDING.md & onboarding.md
Committers 1
 - Hardanish Singh <[email protected]>
PR-URL: https://github.com/nodejs/node/pull/61267
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/61267
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sat, 03 Jan 2026 23:33:16 GMT
   ✔  Approvals: 5
   ✔  - Gireesh Punathil (@gireeshpunathil) (TSC): https://github.com/nodejs/node/pull/61267#pullrequestreview-3624635596
   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/61267#pullrequestreview-3625066977
   ✔  - Colin Ihrig (@cjihrig): https://github.com/nodejs/node/pull/61267#pullrequestreview-3625085707
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/61267#pullrequestreview-3625102285
   ✔  - Rafael Gonzaga (@RafaelGSS) (TSC): https://github.com/nodejs/node/pull/61267#pullrequestreview-3625181848
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 61267
From https://github.com/nodejs/node
 * branch                  refs/pull/61267/merge -> FETCH_HEAD
✔  Fetched commits as ac73a0799a1f..d4ec22fb6a31
--------------------------------------------------------------------------------
Auto-merging BUILDING.md
[main 07d56711a4] doc: fix typos and grammar in BUILDING.md
 Author: Hardanish Singh <[email protected]>
 Date: Sat Jan 3 18:30:43 2026 -0500
 1 file changed, 3 insertions(+), 3 deletions(-)
[main f382f8f3f3] doc: fix typos and grammar in BUILDING.md
 Author: Hardanish Singh <[email protected]>
 Date: Sat Jan 3 19:57:55 2026 -0500
 1 file changed, 1 insertion(+), 1 deletion(-)
[main 1470467139] doc: fix typos and grammar in BUILDING.md
 Author: Hardanish Singh <[email protected]>
 Date: Sat Jan 3 20:04:51 2026 -0500
 1 file changed, 2 insertions(+), 2 deletions(-)
[main 80dcf7b7b2] doc: fix typos and grammar in BUILDING.md & onboarding.md
 Author: Hardanish Singh <[email protected]>
 Date: Sun Jan 4 10:33:27 2026 -0500
 2 files changed, 2 insertions(+), 2 deletions(-)
   ✔  Patches applied
There are 4 commits in the PR. Attempting autorebase.
(node:2268) [DEP0190] DeprecationWarning: Passing args to a child process with shell option true can lead to security vulnerabilities, as the arguments are not escaped, only concatenated.
(Use `node --trace-deprecation ...` to show where the warning was created)
Rebasing (2/8)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
doc: fix typos and grammar in BUILDING.md
PR-URL: #61267

Reviewed-By: Gireesh Punathil <[email protected]>

Reviewed-By: Antoine du Hamel <[email protected]>

Reviewed-By: Colin Ihrig <[email protected]>

Reviewed-By: Luigi Pinca <[email protected]>

Reviewed-By: Rafael Gonzaga <[email protected]>
[detached HEAD 76fb72108e] doc: fix typos and grammar in BUILDING.md

Author: Hardanish Singh <[email protected]>

Date: Sat Jan 3 18:30:43 2026 -0500

1 file changed, 3 insertions(+), 3 deletions(-)

Rebasing (3/8)

Rebasing (4/8)

Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

doc: fix typos and grammar in BUILDING.md
PR-URL: #61267

Reviewed-By: Gireesh Punathil <[email protected]>

Reviewed-By: Antoine du Hamel <[email protected]>

Reviewed-By: Colin Ihrig <[email protected]>

Reviewed-By: Luigi Pinca <[email protected]>

Reviewed-By: Rafael Gonzaga <[email protected]>
[detached HEAD 66b4d768bc] doc: fix typos and grammar in BUILDING.md

Author: Hardanish Singh <[email protected]>

Date: Sat Jan 3 19:57:55 2026 -0500

1 file changed, 1 insertion(+), 1 deletion(-)

Rebasing (5/8)

Rebasing (6/8)

Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

doc: fix typos and grammar in BUILDING.md
PR-URL: #61267

Reviewed-By: Gireesh Punathil <[email protected]>

Reviewed-By: Antoine du Hamel <[email protected]>

Reviewed-By: Colin Ihrig <[email protected]>

Reviewed-By: Luigi Pinca <[email protected]>

Reviewed-By: Rafael Gonzaga <[email protected]>
[detached HEAD 66590585bb] doc: fix typos and grammar in BUILDING.md

Author: Hardanish Singh <[email protected]>

Date: Sat Jan 3 20:04:51 2026 -0500

1 file changed, 2 insertions(+), 2 deletions(-)

Rebasing (7/8)

Rebasing (8/8)

Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

doc: fix typos and grammar in BUILDING.md & onboarding.md
PR-URL: #61267

Reviewed-By: Gireesh Punathil <[email protected]>

Reviewed-By: Antoine du Hamel <[email protected]>

Reviewed-By: Colin Ihrig <[email protected]>

Reviewed-By: Luigi Pinca <[email protected]>

Reviewed-By: Rafael Gonzaga <[email protected]>
[detached HEAD 3746d6c4a7] doc: fix typos and grammar in BUILDING.md & onboarding.md

Author: Hardanish Singh <[email protected]>

Date: Sun Jan 4 10:33:27 2026 -0500

2 files changed, 2 insertions(+), 2 deletions(-)

Successfully rebased and updated refs/heads/main.
ℹ  Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/20732625747

aduh95 · 2026-01-06T08:52:17Z

Landed in 2030fd3

doc: fix typos and grammar in BUILDING.md

9e37f5a

nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. labels Jan 3, 2026

Hardanish-Singh added 2 commits January 3, 2026 19:57

doc: fix typos and grammar in BUILDING.md

d46d744

doc: fix typos and grammar in BUILDING.md

32d4e00

gireeshpunathil approved these changes Jan 4, 2026

View reviewed changes

MikeMcC399 reviewed Jan 4, 2026

View reviewed changes

BUILDING.md Outdated Show resolved Hide resolved

MikeMcC399 reviewed Jan 4, 2026

View reviewed changes

onboarding.md Show resolved Hide resolved

MikeMcC399 mentioned this pull request Jan 4, 2026

doc: correct typo in BUILDING doc #61261

Merged

MikeMcC399 reviewed Jan 4, 2026

View reviewed changes

onboarding.md Outdated Show resolved Hide resolved

Hardanish-Singh changed the title ~~doc: fix typos and grammar in BUILDING.md~~ doc: fix typos and grammar in BUILDING.md & onboarding.md Jan 4, 2026

Hardanish-Singh requested a review from MikeMcC399 January 4, 2026 15:33

doc: fix typos and grammar in BUILDING.md & onboarding.md

d4ec22f

This comment was marked as resolved.

Sign in to view

aduh95 approved these changes Jan 4, 2026

View reviewed changes

cjihrig approved these changes Jan 4, 2026

View reviewed changes

lpinca approved these changes Jan 4, 2026

View reviewed changes

RafaelGSS approved these changes Jan 4, 2026

View reviewed changes

aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 5, 2026

avivkeller added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 5, 2026

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jan 5, 2026

aduh95 merged commit 2030fd3 into nodejs:main Jan 6, 2026
27 checks passed

Uh oh!

doc: fix typos and grammar in BUILDING.md & onboarding.md #61267

doc: fix typos and grammar in BUILDING.md & onboarding.md #61267

Conversation

Hardanish-Singh commented Jan 3, 2026

Uh oh!

nodejs-github-bot commented Jan 3, 2026

Uh oh!

Hardanish-Singh commented Jan 3, 2026

Uh oh!

Xstoudi commented Jan 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Hardanish-Singh commented Jan 4, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as resolved.

Uh oh!

aduh95 left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Jan 5, 2026

PR-URL: #61267 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>

PR-URL: #61267 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>

PR-URL: #61267 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>

PR-URL: #61267 Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: Antoine du Hamel <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Rafael Gonzaga <[email protected]>

[detached HEAD 3746d6c4a7] doc: fix typos and grammar in BUILDING.md & onboarding.md Author: Hardanish Singh <[email protected]> Date: Sun Jan 4 10:33:27 2026 -0500 2 files changed, 2 insertions(+), 2 deletions(-) Successfully rebased and updated refs/heads/main.

Uh oh!

Uh oh!

aduh95 commented Jan 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

Xstoudi commented Jan 4, 2026 •

edited

Loading

PR-URL: #61267
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>

PR-URL: #61267
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>

PR-URL: #61267
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>

PR-URL: #61267
Reviewed-By: Gireesh Punathil <[email protected]>
Reviewed-By: Antoine du Hamel <[email protected]>
Reviewed-By: Colin Ihrig <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Rafael Gonzaga <[email protected]>

[detached HEAD 3746d6c4a7] doc: fix typos and grammar in BUILDING.md & onboarding.md
Author: Hardanish Singh <[email protected]>
Date: Sun Jan 4 10:33:27 2026 -0500
2 files changed, 2 insertions(+), 2 deletions(-)
Successfully rebased and updated refs/heads/main.