Skip to content

Conversation

@arturgawlik
Copy link
Contributor

This PR enhance error message when WebAssembly global is not available.
Was:
Image
After changes in this PR:
image

This fixes nodejs/node#61353

@arturgawlik arturgawlik force-pushed the fix-error-message-when-referencing-not-existing-webassembly-global branch from 2ba18d0 to 30ed7f2 Compare January 11, 2026 15:05
@arturgawlik
Copy link
Contributor Author

arturgawlik commented Jan 12, 2026

Since issue nodejs/node#61353 was moved away from https://github.com/nodejs/amaro, then I guess we would want to have check implemented in this PR to be in https://github.com/nodejs/node itself + also make same assertion when loading undici.

But at the other side, I think that maybe it would be cleaner if such assertion will sit as close as possible to the code which is using WebAssembly, so it would be:

  1. here in Amaro
  2. but also additional assertion in https://github.com/nodejs/undici just before WebAssembly is actually used

@marco-ippolito
Copy link
Member

lib/wasm.js is auto generated during dependencies update. The check should be performed in Node.js before initializing the parser

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

When Node.js is run with Amaro, but also with --jitless flag error message about lack of WebAssembly global could be more descriptive

2 participants