✨ MediaPlayerService audio implementation - #2
Merged
Conversation
🔊 Added basic logging system ♻️ Cleaned MainWindow.axaml.cs -> MediaPlayerService.cs -> FileHelper.cs Signed-off-by: selkij <selk11@proton.me>
🚚 Renamed MediaPlayerService.cs to AudioPlayerService.cs. ➕ Added TagLibSharp as a dependency. 📝 Added TagLibSharp in the acknowledgements tab. Signed-off-by: selkij <selk11@proton.me>
selkij
marked this pull request as ready for review
September 13, 2025 10:22
Signed-off-by: selkij <selk11@proton.me>
Contributor
Author
|
There's apparently a problem, on certain files the metadata picking fails and crashes, there's also no apparent logging messages appearing. |
🥅 Added try catches when needed
Michalex37220
approved these changes
Sep 14, 2025
Michalex37220
left a comment
Michalex37220
left a comment
Collaborator
There was a problem hiding this comment.
Good implementation, can lag on potato pc i think ? and maybe some bug but i didn't found it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this we will be able to play audio files, locally and remotely.
Features:
To-Do: