Skip to content

fix wrong default value of session lock integration state#3149

Open
Alper-Celik wants to merge 3 commits into
noctalia-dev:mainfrom
Alper-Celik:logind
Open

fix wrong default value of session lock integration state#3149
Alper-Celik wants to merge 3 commits into
noctalia-dev:mainfrom
Alper-Celik:logind

Conversation

@Alper-Celik

Copy link
Copy Markdown

Summary

since integration checks the state of the integration when setting it enabled or disabled. it doesnt enable it if it is defaulted to true since applicaion tries to set it to enabled but since value is already set to enabled it ignores it.

so before this commit you need to enable than disable the lockscreen to get lockscreen integration working

Motivation

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Refactoring
  • Build / packaging

Related Issue

Testing

Manual Coverage

  • Tested on Niri
  • Tested on Hyprland
  • Tested on Sway
  • Tested on another compositor:
  • Tested with different bar positions and density settings
  • Tested at different interface scaling values
  • Tested with multiple monitors

Screenshots / Videos

Checklist

  • This PR is ready for review, or it is marked as Draft.
  • I read and followed the relevant guidance in CONTRIBUTING.md.
  • I ran just format with clang-format v22+ installed, or this PR has no code changes.
  • I ran the relevant build or test commands, or explained why they were not run.
  • I self-reviewed the changes.
  • I checked for new warnings or errors.
  • I will update end-user documentation after merge, or this PR does not change user-facing configuration or behavior.
  • I added or updated assets/translations/en.json, or this PR adds no new user-facing strings.
  • I did not edit non-English translation files unless this PR is explicitly for translation tooling, an import/export sync, or a maintainer-requested locale change.
  • I used the existing canonical names for config keys, IPC names, paths, and identifiers.

Additional Notes

since integration checks the state of the integration when setting it
enabled or disabled. it doesnt enable it if it is defaulted to true
since applicaion tries to set it to enabled but since value is already
set to enabled it ignores it.

so before this commit you need to enable than disable the lockscreen to
get lockscreen integration working
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant