fix(discord-midnight): improve channel text contrast and accent color mappings#27
Open
the-daonm wants to merge 1 commit into
Open
fix(discord-midnight): improve channel text contrast and accent color mappings#27the-daonm wants to merge 1 commit into
the-daonm wants to merge 1 commit into
Conversation
|
I think normal text also has a bad contrast in dark mode. Maybe change |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request resolves contrast and color mapping issues in the
discord-midnightcommunity template when rendered with different color palettes (e.g. Gruvbox Material).Changes Made
1. Text Contrast Fix (
--text-4,--text-5)--text-4) and muted chats/timestamps (--text-5) directly tocolors.outlineandcolors.outline_variant. In dark mode, these resolve to very dark grey/near-black border colors, making the channel list text and timestamps completely unreadable.--text-4mixes 65% of the primary foreground (on_surface) with 35% outline, creating a legible cream-grey.--text-5mixes 40% foreground with 60% outline, producing a clean, muted, yet readable gray.discord-system24and works correctly for both light and dark shell modes.2. Accent Mappings Fix (
--accent-2,--accent-4)--accent-2(small accent elements, such as chosen/selected channel indicators) was mapped to a dark container background color (primary_container), which was invisible on dark backgrounds.--accent-4(hovered accent buttons) was mapped to a light text color (on_secondary_container), causing harsh brightness inconsistencies.--accent-2to the primary accent color (colors.primary), keeping active channel selections highlighted in the theme's primary accent color (e.g. Gruvbox green).--accent-4to a 80% secondary accent mix, creating a smooth and cohesive color shift on hover.Type of Change
How Has This Been Tested?
noctalia.theme.css) locally on Vesktop using the Gruvbox Material palette (both dark and light modes).