fix: return error in SigVerificationDecorator to avoid panic#28
Closed
fix: return error in SigVerificationDecorator to avoid panic#28
SigVerificationDecorator to avoid panic#28Conversation
WalkthroughThe changes refactor the balance and signer validation logic in the Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant SigVerificationDecorator
participant Account
participant NextAnteHandler
Client->>SigVerificationDecorator: AnteHandle(request)
SigVerificationDecorator->>Account: Check if signer matches address
alt Signer does not match
SigVerificationDecorator->>NextAnteHandler: Delegate AnteHandle
else Signer matches
SigVerificationDecorator->>Account: Fetch balance
alt Balance is zero
SigVerificationDecorator->>Client: Return ErrInvalidAccountBalance
else Balance is non-zero
SigVerificationDecorator->>NextAnteHandler: Call AnteHandle
end
end
Suggested reviewers
Poem
Tip ⚡️ Faster reviews with caching
Enjoy the performance boost—your workflow just got faster. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
✅ Files skipped from review due to trivial changes (2)
⏰ Context from checks skipped due to timeout of 90000ms (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
0xstepit
changed the title
SigVerificationDecorator to avoid panic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the current ante implementation, if the account considered as signer is a Forwarding account, and it does not have a balance, a panic is triggered during signerless registration. This panic is recovered, so does not cause liveness issues, but can be quickly fixed.
The error returned is reported here to keep track of it in case it can be of any help in the future:
Summary by CodeRabbit