fix(site): align hosted native smoke and wasm with protocol 0.9 - #694
Merged
Merged
Conversation
#689 pinned the native image to workspace 0.37.0 (protocol 0.9). Site smoke and the committed browser/edge wasm still spoke protocol 0.2/0.5, so native HELLO failed and the worker relayed websocket close 1000 (run 34957405348). Rebuild in-repo phux-web with start_hosted, rebuild phux-edge for 0.9 HELLO_OK plus READY-fenced bootstrap, and teach smoke to wait for HELLO_OK before ATTACH. Native image pin is unchanged. Co-authored-by: phall <phall1@users.noreply.github.com>
Merged
phall1
added a commit
that referenced
this pull request
Sep 15, 2026
#694 restored protocol 0.9 smoke/wasm, then merged onto #655's 0.38.0 release. site-deploy-worker validate requires Dockerfile PHUX_VERSION to match workspace.package.version, so the 0.37.0 pin failed before smoke ran (run 34965350011). Point the native archive at the 0.38.0 release commit. Protocol remains 0.9; this is the same pin policy as #689, not a rollback and not a change to #655 itself. Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: phall <phall1@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cause
site-deploy-workerfailed on main after #689:60b63a9(fix(site): pin hosted native phux to workspace 0.37.0)/healthzstayed OKsmoke-native.ts:170:native websocket closed before verification code=1000This is the HELLO mismatch #689 warned about, confirmed from logs + wire bytes:
worker/Dockerfile)phux-tui/test,protocol_minor=2) and ATTACH on openstart_hostedbackport (fe1f9563)phux-serverrequiresmajor.minormatch; mismatch →ERROR+ close, relayed as WS 1000--exercise-fallbackuses the same HELLO for native then edge, so smoke, edge, and the hosted browser client all had to move to 0.9 together. Native image pin is unchanged.Fix
Surgical protocol alignment only. No architecture rewrite. Does not touch release #655.
ClientCapabilities::new(), CreateIfMissingname=default). Smoke waits for the session envelope, thenHELLO_OK, then ATTACH. ParsesRESOURCE_OUTPUTandBootstrapChunk. Fails onERROR.phux-edgedepends on in-treephux-protocol0.37.0 and speaks 0.9HELLO_OK+ READY-fenced bootstrap (greeting inBootstrapChunk).clients/phux-webgrowsstart_hosted(wait forphux.session.v1text, then HELLO). Committed site wasm rebuilt from this checkout instead of the 0.5 pin.build-client.shbuilds from this repo.How to verify
Local (already run on this branch):
137 site tests pass; 11 edge tests pass, including HELLO 0.9 and smoke-byte lockstep.
Production path: merge to main retriggers both deploys.
site-deploy-worker(paths includedocs/site/worker/**,docs/site/edge/**,phux-wire.ts,smoke-native.ts) redeploys Worker + edge wasm and re-runsworker:smoke-fallbacksite-deploy(docs/**) republishes the 0.9 browser wasm so the live demo matches nativeNative container image is unchanged from #689; only Worker/edge/smoke/browser wasm move. After merge, the
site-deploy-workersmoke step is the live confirmation. No Cloudflare secrets were required for this in-repo fix.Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.