Open
Conversation
nmeum
commented
Aug 29, 2018
Author
There was a problem hiding this comment.
EDIT: Never mind, I just went ahead and adjusted the regex to parse the URI.
The change made in 6886015 is not strictly necessary. It would also be possible to extract the scheme using the regex, however, I was to lazy to adjust the regex and I believe that it is cleaner to use the URI module.
Also make scheme_and_authority_decode return the URL scheme.
nning
reviewed
Jan 19, 2019
Owner
nning
left a comment
nning
left a comment
There was a problem hiding this comment.
Is still a pre-release version of tinydtls required?
|
Yes, unfortunately, there is no official tinydtls release yet. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As with nning/david#16 this is implemented using the
tinydtlsruby gem. This particular pull request requires the unreleased version0.3.0preof the tinydtls rubygem since versions< 0.3.0predo not support theMSG_PEEKrecvfrom flag.While we can only support the
PreSharkedKeymode specified in RFC 7252 with thetinydtlsrubygem. I believe that this is a step in the right direction. Support for this DTLS mode in the coap gem would also allow writing tests for nning/david#16.Contrarry to nning/david#16 the changes made here are not considered WIP and could imho be merged as is.
CC: @obgm