Harden transient validation notebook with decoupled methods and runtime parameter reporting#108
Open
ehavazli wants to merge 13 commits into
Open
Harden transient validation notebook with decoupled methods and runtime parameter reporting#108ehavazli wants to merge 13 commits into
ehavazli wants to merge 13 commits into
Conversation
Method 1 (GNSS-InSAR comparison) can now fail without blocking Method 2 (noise level validation). Changes: - Wrap Method 1 computation (cells 84-88) in try-except block - Guard Method 1 display/save cells with `if method1_ok:` check - Remove Method 2 dependencies on Method 1 variables: - Use `n_ifgs_method2 = len(ifgs_date)` instead of `len(ddiff_dist_ap1)` - Use `range(n_ifgs_method2)` instead of `displacement.index` iteration - Method 2 creates own `run_date_method2` and `method2_summary` - Appendix plots (cells 150-153) guarded with `if method1_ok:` Result: Run All continues to Method 2 even when Method 1 fails (e.g., insufficient GNSS stations).
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Harden transient validation notebook with decoupled methods and runtime parameter reporting
Decouples Method 1 (GNSS-InSAR) and Method 2 (noise-level) validation flows so each can fail independently without breaking the entire notebook. Key improvements:
method1_ok,method2_ok) and failure handlers, eliminating cascading failureseffective_*fieldssubprocess.run()calls throughout correction setup and reference point flowsFixes validation report parameter confusion where users couldn't tell which GNSS station was actually used vs what was configured, and prevents notebook crashes when one method fails.