fix(app-tools): unpack native companion libraries - #149
Merged
Merged
Conversation
Signed-off-by: snowzane <eric.3126@gmail.com>
Deploying nimi-doc with
|
| Latest commit: |
8cbbd64
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://adcce5fa.nimi-doc.pages.dev |
| Branch Preview URL: | https://codex-app-tools-native-unpac.nimi-doc.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The published Next AI Draw.io package failed before opening a window because the scaffold's ASAR rule unpacked Sharp's native add-on but left its libvips dylib inside the archive. App Tools 0.6.3 preserves the on-disk layout of
.node,.dylib, and.dllfiles for the supported Mac/Windows targets. Existing App-owned packagers receive the same guidance through the release skill and README.Scope
Verification
pnpm --filter @nimiplatform/app-tools test pnpm release:component:pack -- --component app-tools --output-dir dist/component-release/app-tools-0.6.3 pnpm check:package-license-matrix pnpm check:sdk-version-matrix git diff --checkBreaking Changes
None. Existing App-owned packagers need the documented rule; sync does not overwrite their code.
Security Impact
Low: dependency libraries remain at their original relative paths outside ASAR so the OS loader can resolve them. Publisher signing/sealing and Runtime verification remain unchanged.
Rollback Plan
No data migration. A correction to a published package uses a new version; immutable releases remain unchanged.
Docs
Updated the package README, release skill, and starter README, including the stale
asar: falsedescription.DCO