changes supporting or noticed due to work on nimbleModel#190
Merged
Conversation
Contributor
Author
|
There is a test failure that appears unrelated and was noted in #192 . I will proceed with merging this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has some mostly minor changes arising from work on nimbleModel.
initializemethod has includedsuper$initialize(...), which they need to.initializetakes arguments before theCppObjargument (that latter of which should be captured in...)Assignthat accidentally avoided use offlex_()on the LHS.set_all_valuesfrom a list fornListobjects with flexibility for whether the input list is compiled or uncompiled and whether each element is compiled or uncompiled.I am entering this PR before running tests, which I will go do next.