Icon dynamic PoC #2827
Draft
Icon dynamic PoC #2827
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajsite
commented
Jan 23, 2026
| { | ||
| var prefersDark = await JSRuntime!.InvokeAsync<bool>("DemoShared.PrefersColorScheme.prefersDark"); | ||
| Theme = prefersDark ? Theme.Dark : Theme.Light; | ||
| await JSRuntime!.InvokeVoidAsync( |
Member
Author
There was a problem hiding this comment.
We should make a new helper component in the OkBlazor library like OkIconDynamic that has a static function to call this for the user.
Something like:
public partial class OkIconDynamic : ComponentBase
{
public static async Task RegisterIconDynamicAsync(IJSRuntime jsRuntime, string name, string url)
{
await jsRuntime.InvokeVoidAsync(
"DemoShared.IconDynamic.registerIconDynamic",
name,
url);
}
}
rajsite
commented
Jan 23, 2026
Comment on lines
+70
to
+75
| IconDynamic: { | ||
| registerIconDynamic: function (name, url) { | ||
| const registerIconDynamic = window.customElements.get('ok-icon-dynamic').registerIconDynamic; | ||
| registerIconDynamic(name, url); | ||
| } | ||
| } |
Member
Author
There was a problem hiding this comment.
To align with above, this should be moved to the OkBlazor.lib.module.js in the window.OkBlazor object:
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
👩💻 Implementation
🧪 Testing
✅ Checklist