rigol function generator

[pepijndevos]

I've confirmed the minimal functionality works, but have not done very exhaustive testing.

One thing I noticed is that detecting if the scope has the function generator basically doesn't work.
I'm not sure what the hacky solution is and how to test it.

Another thing is, it's not documented what the units are in the API.
For example, Rigol takes duty cycle in percent, but maybe the API is between 0 and 1?

[azonenberg]

Will have a look in a bit.

The function generator API is currently in its infancy right now because glscopeclient lacks any UI for invoking it. The only func gen driver we have right now is for the Teledyne LeCroy WaveSurfer 3000 series IIRC, and I haven't touched it in years.

Let's keep this pending until I've had time to finalize and document the API then you can tweak as needed to match?

[pepijndevos]

The commands I implemented so far are a perfect one-to-one match to the Rigol API, which to me seems to be a pretty good indication that the current API is right. So I'd say it's probably good to merge, and just add no-ops when you extend the API.

I could add some comments to sketch out the functionality Rigol has that's not yet exposed. Then you have some idea for N=2 what generalizes between WaveSurfer (high end) and Rigol (low end)

[bvernoux]

@pepijndevos Any update on that PR ? (it seems abandoned/unfinished since more than 1 year now ?)

[pepijndevos]

It's basically waiting for @azonenberg to stabilize the function generator API

Let's keep this pending until I've had time to finalize and document the API then you can tweak as needed to match?