-
Notifications
You must be signed in to change notification settings - Fork 707
fix(export): prevent left-side crop of exported images on Windows #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
111wukong
wants to merge
3
commits into
nexu-io:main
Choose a base branch
from
111wukong:fix/image-export-left-crop
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+40
−4
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These two DeepSeek entries are added to the Claude Code adapter's
fallbackModels, but unlike the Claude/alias models above them they only resolve when the user has routed Claude Code through a custom model endpoint (e.g. viacc switch). For a user who has not done that, pickingdeepseek-v4-prohere makesinvokeAgentrunclaude --model deepseek-v4-pro, which the stock Claude CLI/API rejects with an opaque "unknown model" failure surfaced as a failed run.Why it matters: the new code comment documents this precondition for developers, but the user-facing
label("deepseek-v4-pro") gives the end user no hint that these require a routed setup. The picker therefore advertises two models that fail by default, which works against the "Curated, evidence-based model list" intent documented onAgentDef.fallbackModels(lines 37-40) and onDEFAULT_MODEL.Suggested change: surface the precondition in the user-visible label, e.g.
🔁 Powered by Looper · runner=reviewer · agent=claude-code · An autonomous AI dev team for your GitHub repos.{ id: "deepseek-v4-pro", label: "deepseek-v4-pro (routed endpoint)" }and likewise fordeepseek-v4-flash; or gate these two entries behind a detected routed config so they only appear when usable. This is a nit, not merge-blocking.