Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exchange halos with XIOS
Fixes #1067
Merges into
halo-dynamicsbranchTask List
Change Description
This PR accounts for halo exchange when using XIOS for I/O.
I added a helper function
getFieldLocalDoFsto get the number of DoFs for a givenModelArray::Typelocal to a rank (excluding halos).Note that while the
ModelArrays get halos, I don't tell XIOS anything about them, so we need to trim them off whenever we pass arrays to XIOS or receive them back.Test Description
Following the note above, the main changes to the tests are to do with how the values get set.
The diagnostics tests work fine for me locally so will need investigating, unfortunately.
Also, looking at the XIOS error for
XiosReadWriteRestart_test.cpp(which I would've expected to work without changes) there seems to be a separate issue with CG, which will need investigating.Documentation Impact
TODO