Skip to content

Exchange halos with XIOS#1069

Draft
joewallwork wants to merge 9 commits intohalo-dynamicsfrom
issue1067_xios-halo-exchange-take2
Draft

Exchange halos with XIOS#1069
joewallwork wants to merge 9 commits intohalo-dynamicsfrom
issue1067_xios-halo-exchange-take2

Conversation

@joewallwork
Copy link
Copy Markdown
Contributor

@joewallwork joewallwork commented Mar 26, 2026

Exchange halos with XIOS

Fixes #1067
Merges into halo-dynamics branch

Task List

  • Linked an issue above that captures the requirements of this PR
  • Defined the tests that specify a complete and functioning change
  • Implemented the source code change that satisfies the tests
  • Commented all code so that it can be understood without additional context
  • No new warnings are generated or they are mentioned below
  • The documentation has been updated (or an issue has been created to do so)
  • Relevant labels (e.g., enhancement, bug) have been applied to this PR
  • This change conforms to the conventions described in the README

Change Description

This PR accounts for halo exchange when using XIOS for I/O.

I added a helper function getFieldLocalDoFs to get the number of DoFs for a given ModelArray::Type local to a rank (excluding halos).

Note that while the ModelArrays get halos, I don't tell XIOS anything about them, so we need to trim them off whenever we pass arrays to XIOS or receive them back.


Test Description

Following the note above, the main changes to the tests are to do with how the values get set.

  • Forcing test
  • [/] Diagnostics tests
  • Restarts tests

The diagnostics tests work fine for me locally so will need investigating, unfortunately.

Also, looking at the XIOS error for XiosReadWriteRestart_test.cpp (which I would've expected to work without changes) there seems to be a separate issue with CG, which will need investigating.


Documentation Impact

TODO

@joewallwork joewallwork added enhancement New feature or request ICCS Tasks or reviews for the ICCS team labels Mar 26, 2026
@joewallwork joewallwork linked an issue Mar 26, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request ICCS Tasks or reviews for the ICCS team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Exchange halos with XIOS

2 participants