Skip to content

Fix respect view column order in public sharing #2701

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
taiebot wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Fix respect view column order in public sharing #2701

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
b21c838
Fix column filter in public sharing
taiebot Jun 5, 2026
77b420b
Merge branch 'nextcloud:main' into Fix-view-6
taiebot Jun 15, 2026
1b3cb62
Fix eslint issue
taiebot Jun 15, 2026
61f7f28
Fix eslint again
taiebot Jun 16, 2026
006aebf
Fix eslint
taiebot Jun 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions src/store/data.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,12 +118,13 @@ export const useDataStore = defineStore('data', {
displayError(e, t('tables', 'Could not load columns.'))
return []
}

const columns = res.data.ocs.data.map(col => parseCol(col))
.sort((a, b) => a.id - b.id)
// Fix up columns to match expected structure if needed
// Public API might return slightly different structure, but parseCol should handle it if it's standard TableColumn

const columns = [...res.data.ocs.data]
.sort((a, b) => {
const orderA = a.viewColumnInformation?.order ?? Number.MAX_SAFE_INTEGER
const orderB = b.viewColumnInformation?.order ?? Number.MAX_SAFE_INTEGER
return orderA - orderB
})
.map(col => parseCol(col))
set(this.columns, stateId, columns)
this.loading[stateId] = false
return columns
Expand Down