Skip to content

fix(widget): allow to show file share as widget if possible#13271

Draft
Antreesy wants to merge 1 commit into
mainfrom
feat/noid/toggle-inline-editor
Draft

fix(widget): allow to show file share as widget if possible#13271
Antreesy wants to merge 1 commit into
mainfrom
feat/noid/toggle-inline-editor

Conversation

@Antreesy

@Antreesy Antreesy commented Sep 11, 2024

Copy link
Copy Markdown
Contributor

☑️ Resolves

🖌️ UI Checklist

2024-09-11_16h21_14.mp4

🚧 Tasks

  • ...

🏁 Checklist

  • 🌏 Tested with different browsers / clients:
    • Chromium (Chrome / Edge / Opera / Brave)
    • Firefox
    • Safari
    • Talk Desktop
    • Not risky to browser differences / client
  • 🖌️ Design was reviewed, approved or inspired by the design team
  • ⛑️ Tests are included or not possible
  • 📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
@marcoambrosini

Copy link
Copy Markdown
Member

@Antreesy would interadcive widget be disabled by default then?

@Antreesy

Antreesy commented Sep 14, 2024

Copy link
Copy Markdown
Contributor Author

would interactive widget be disabled by default then?

No, that's different) Currently:

  • if you share a file, we show only a file preview;
  • if you post an internal link, we show an interactive widget embedded;

This PR allows to toggle file share preview <=> embedded widget on user demand.
So if you share a link, there is no way to turn widget into static preview

@marcoambrosini marcoambrosini left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For this I would add a button close to the preview. Using something like this as icon.

https://fonts.google.com/icons?selected=Material+Symbols+Outlined:expand_content:FILL@0;wght@400;GRAD@0;opsz@24&icon.query=open&icon.size=24&icon.color=%235f6368

Ideally somewhere where it stays on the same place, so that I can quickly expand and collapse the view

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement feature: frontend 🖌️ "Web UI" client feature: upload & shares & voice 📤🎙️ Sharing files into a chat and audio recordings

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants