Skip to content

[stable32] fix(theming): preserve uploaded favicon and touch icon#61255

Open
backportbot[bot] wants to merge 1 commit into
stable32from
backport/61253/stable32
Open

[stable32] fix(theming): preserve uploaded favicon and touch icon#61255
backportbot[bot] wants to merge 1 commit into
stable32from
backport/61253/stable32

Conversation

@backportbot

@backportbot backportbot Bot commented Jun 12, 2026

Copy link
Copy Markdown

Backport of PR #61253

@backportbot backportbot Bot requested a review from a team as a code owner June 12, 2026 15:28
@backportbot backportbot Bot requested review from Altahrim, ArtificialOwl, leftybournes, salmart-dev and szaimen and removed request for a team June 12, 2026 15:28
@backportbot backportbot Bot added this to the Nextcloud 32.0.12 milestone Jun 12, 2026
@szaimen szaimen marked this pull request as draft June 12, 2026 15:28
PR #58224 dropped the `$iconFile === null` guard around the app-specific
icon generation in getFavicon()/getTouchIcon(), so an uploaded custom
favicon was always overwritten by the generated, context-colored icon
whenever Imagick could produce an ICO/PNG.

Restore the guard so the generation path only runs as a fallback when no
custom favicon was uploaded, while keeping the improved Imagick
capability detection from #58224.

Assisted-by: ClaudeCode:claude-opus-4-8
Signed-off-by: Simon L. <szaimen@e.mail.de>
@szaimen szaimen force-pushed the backport/61253/stable32 branch from 15fc69e to 7b0f83f Compare June 13, 2026 20:14
@szaimen szaimen marked this pull request as ready for review June 13, 2026 20:14
@szaimen

szaimen commented Jun 13, 2026

Copy link
Copy Markdown
Contributor

CI failure is unrelated afaics and the customer already reported back that this PR fixes the problem for them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant