Skip to content

test: Fix DB test grouping#61215

Draft
provokateurin wants to merge 5 commits into
masterfrom
test/database-check
Draft

test: Fix DB test grouping#61215
provokateurin wants to merge 5 commits into
masterfrom
test/database-check

Conversation

@provokateurin

@provokateurin provokateurin commented Jun 11, 2026

Copy link
Copy Markdown
Member

Some tests are using the database, but weren't running in the DB group, and some tests are running in the DB group, but weren't using the database. The check if the database is actually used is much more accurate now. Overall the change will reduce the number of tests, because many are deduplicated by only running them on nodb.

@provokateurin provokateurin added this to the Nextcloud 35 milestone Jun 11, 2026
@provokateurin provokateurin requested review from artonge and come-nc June 11, 2026 17:00
@provokateurin provokateurin added 3. to review Waiting for reviews CI labels Jun 11, 2026
@provokateurin provokateurin requested review from ArtificialOwl and leftybournes and removed request for a team June 11, 2026 17:00
Comment thread tests/lib/Files/Storage/Wrapper/QuotaTest.php
Comment thread tests/lib/TestCase.php Outdated

@ChristophWurst ChristophWurst left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff

Signed-off-by: provokateurin <kate@provokateurin.de>
Signed-off-by: provokateurin <kate@provokateurin.de>
Signed-off-by: provokateurin <kate@provokateurin.de>
Signed-off-by: provokateurin <kate@provokateurin.de>
Signed-off-by: provokateurin <kate@provokateurin.de>
@susnux

susnux commented Jun 11, 2026

Copy link
Copy Markdown
Contributor
grafik grafik

looks related

@provokateurin provokateurin marked this pull request as draft June 11, 2026 21:12
auto-merge was automatically disabled June 11, 2026 21:12

Pull request was converted to draft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants