Skip to content

fix: resolve PHP deprecation of imagedestroy#61176

Merged
provokateurin merged 1 commit into
masterfrom
fix/deprecated-85
Jun 11, 2026
Merged

fix: resolve PHP deprecation of imagedestroy#61176
provokateurin merged 1 commit into
masterfrom
fix/deprecated-85

Conversation

@susnux

@susnux susnux commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Prior to PHP 8.0.0, imagedestroy() freed any memory associated with the image resource.
As of 8.0.0, the GD extension uses objects instead of resources, and objects cannot be explicitly closed.

With PHP 8.5 this is deprecated and causes a deprecation warning!

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

> Prior to PHP 8.0.0, imagedestroy() freed any memory associated with the image resource.
> As of 8.0.0, the GD extension uses objects instead of resources, and objects cannot be explicitly closed.

With PHP 8.5 this is deprecated and causes a deprecation warning!

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux requested a review from a team as a code owner June 10, 2026 23:00
@susnux susnux requested review from Altahrim, come-nc, icewind1991 and provokateurin and removed request for a team June 10, 2026 23:00
@susnux susnux added this to the Nextcloud 35 milestone Jun 10, 2026
@susnux susnux added 3. to review Waiting for reviews technical debt 🧱 🤔🚀 ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) bug and removed ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) labels Jun 10, 2026
@provokateurin provokateurin enabled auto-merge June 11, 2026 03:42
@provokateurin provokateurin merged commit 0302d60 into master Jun 11, 2026
181 of 196 checks passed
@provokateurin provokateurin deleted the fix/deprecated-85 branch June 11, 2026 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews bug technical debt 🧱 🤔🚀

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants