fix(l10n): make translation factory caches app- and locale-aware#61037
Draft
joshtrichards wants to merge 8 commits into
Draft
fix(l10n): make translation factory caches app- and locale-aware#61037joshtrichards wants to merge 8 commits into
joshtrichards wants to merge 8 commits into
Conversation
…instance cache Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Reuse the already resolved l10n directory instead, preventing an unnecessary exception path for unknown apps Signed-off-by: Josh <josh.t.richards@gmail.com>
Stop populating availableLanguageMap in the cache-hit path and make it lazy in languageExists(). Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
Signed-off-by: Josh <josh.t.richards@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Don't let the number of changed lines scare you; the bulk are either mechanical variable name changes or comment updates/removals.
Improve
OC\L10N\Factorycaching and clean up related internals.Changes
L10Ninstances per app, language, and localelanguageExists()findLanguageFromLocale()for null / empty inputWhy
Factory::get()previously cachedL10Ninstances only by app and language, which could reuse the same instance across different locales.This also makes language lookup caching more explicit and avoids duplicate language entries when app and theme translations overlap.
Testing
TODO
L10Ninstance cachingfindLanguageFromLocale()Checklist
3. to review, feature component)stable32)AI (if applicable)