fix(files_versions): guard null path in event listeners#60842
Open
solracsf wants to merge 1 commit into
Open
Conversation
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves:
Stack trace
Summary
getPathForNode()is typed?string(here) and legitimately returns null when a node cannot be mapped to a user-relative path, e.g. a public-link or group folder WebDAV operation where there is no session user and no per-user owner path.Five of its six callers passed that null straight into Storage methods, which forward it to
Viewmethods typedstring, throwing a TypeError.Checklist
3. to review, feature component)stable32)AI (if applicable)