Skip to content

feat: allow setting custom login-name for occ generated app password#59680

Merged
artonge merged 1 commit into
nextcloud:masterfrom
piepre:occ-token-login-name
Jun 11, 2026
Merged

feat: allow setting custom login-name for occ generated app password#59680
artonge merged 1 commit into
nextcloud:masterfrom
piepre:occ-token-login-name

Conversation

@piepre

@piepre piepre commented Apr 16, 2026

Copy link
Copy Markdown
Contributor

Summary

added the option to set the login_name for auth-tokens created with occ

For example, this can be helpful if you want to automatically integrate CalDAV and CardDAV resources in Thunderbird. See: https://help.nextcloud.com/t/use-mailaddress-instead-of-userid-with-app-password/243247

Example

occ user:add-app-password testuser --login-name=testuser@domain.tld

@piepre piepre requested a review from a team as a code owner April 16, 2026 21:07
@piepre piepre requested review from Altahrim, come-nc, provokateurin and salmart-dev and removed request for a team April 16, 2026 21:07
Comment thread core/Command/User/AuthTokens/Add.php Outdated
@come-nc

come-nc commented Apr 20, 2026

Copy link
Copy Markdown
Contributor

Apart from that, the change makes sense I think. I’m not sure about the option description, "UID" is not that clear in that context, but it’s hard to find the correct phrasing because I’m not sure it’s consistent accross Nextcloud. Maybe "the account name" works, not sure.

@github-actions

github-actions Bot commented May 1, 2026

Copy link
Copy Markdown
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@piepre piepre left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed

@come-nc

come-nc commented May 7, 2026

Copy link
Copy Markdown
Contributor

@piepre Could you rebase and squash as a single commit?

@piepre piepre force-pushed the occ-token-login-name branch from 3e924ce to bb518b6 Compare May 7, 2026 21:08
@piepre

piepre commented May 7, 2026

Copy link
Copy Markdown
Contributor Author

I really have to level up my git skills ;)

@provokateurin provokateurin enabled auto-merge May 11, 2026 07:52
Signed-off-by: piepre <piepre@gmx.de>

Update core/Command/User/AuthTokens/Add.php

Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com>
Signed-off-by: piepre <piepre@gmx.de>
@come-nc come-nc force-pushed the occ-token-login-name branch from bb518b6 to 8998905 Compare May 19, 2026 09:39
@susnux susnux added the community pull requests from community label Jun 9, 2026
@susnux susnux added this to the Nextcloud 35 milestone Jun 9, 2026
@artonge artonge disabled auto-merge June 11, 2026 08:32
@artonge artonge merged commit 15002cb into nextcloud:master Jun 11, 2026
171 of 181 checks passed
@welcome

welcome Bot commented Jun 11, 2026

Copy link
Copy Markdown

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

community pull requests from community feedback-requested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants