Skip to content

refactor(dbal): move from deprecated to modern calls#58891

Open
solracsf wants to merge 1 commit into
masterfrom
executeUpdateRemove
Open

refactor(dbal): move from deprecated to modern calls#58891
solracsf wants to merge 1 commit into
masterfrom
executeUpdateRemove

Conversation

@solracsf

@solracsf solracsf commented Mar 12, 2026

Copy link
Copy Markdown
Member

Summary

Give Doctrine DBAL some love 💘 by moving away from deprecated calls and a few RAW queries.

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@solracsf solracsf added this to the Nextcloud 34 milestone Mar 12, 2026
@solracsf solracsf added the feature: database Database related DB label Mar 12, 2026
@solracsf solracsf changed the title chore(dbal): move to executeStatement chore(dbal): WiP Mar 12, 2026
@solracsf solracsf added 2. developing Work in progress ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring) labels Mar 12, 2026
@solracsf solracsf force-pushed the executeUpdateRemove branch from e9754ab to 2a6989f Compare March 13, 2026 06:25
@solracsf solracsf changed the title chore(dbal): WiP chore(dbal): refactor to modern calls Mar 13, 2026
@solracsf solracsf added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Mar 13, 2026
@solracsf solracsf changed the title chore(dbal): refactor to modern calls refactor(dbal): move from deprecated to modern calls Mar 13, 2026
@solracsf solracsf marked this pull request as ready for review March 13, 2026 07:16
@solracsf solracsf requested review from ArtificialOwl, leftybournes, nfebe and sorbaugh and removed request for a team March 13, 2026 07:16
@solracsf solracsf force-pushed the executeUpdateRemove branch 2 times, most recently from b8d7a73 to 21416b8 Compare March 13, 2026 08:20

@SebastianKrupinski SebastianKrupinski left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CalDav looks fine

Comment thread lib/private/DB/ArrayResult.php Outdated

@miaulalala miaulalala left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as per my other comment

This was referenced Jun 5, 2026
@susnux susnux added the community pull requests from community label Jun 9, 2026
@susnux susnux modified the milestones: Nextcloud 34.0.1, Nextcloud 35 Jun 9, 2026
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
Signed-off-by: Carl Schwan <carlschwan@kde.org>
@CarlSchwan CarlSchwan force-pushed the executeUpdateRemove branch from 21416b8 to c80ae66 Compare June 11, 2026 10:02
@CarlSchwan CarlSchwan enabled auto-merge June 11, 2026 10:02
@CarlSchwan CarlSchwan self-assigned this Jun 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews community pull requests from community feature: database Database related DB ♻️ refactor Refactor code (not a bug fix, not a feature just refactoring)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants