feat (2fa): Add IStatelessProvider interface

[Roszakos]

• Resolves: Stateless 2FA providers #13051

Summary

Adds an IStatelessProvider interface. Per-user 2FA activation state for providers implementing this interface will not be stored in the database, thus isTwoFactorAuthEnabledForUser method will be called on every login attempt.

Checklist

• Code is properly formatted
• Sign-off message is added to all commits
• Tests (unit, integration, api and/or acceptance) are included
• Documentation (manuals or wiki) has been updated or is not required
• Labels added where applicable (ex: bug/enhancement, 3. to review, feature component)
• Milestone added for target branch/version (ex: 32.x for stable32)

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

[come-nc]

Apart from the license issue, looks good 👍

[Furgas]

Is there anything left to do in this pull request? In what version are you plannig to include this change?

[miaulalala]

Looks like you need to update your autoloaders:

The autoloaders are not up to date
Please run: bash build/autoloaderchecker.sh
And commit the result

[Roszakos]

It's done. Let me know if there is anything else that could prevent this change from getting pulled.

[miaulalala]

It's done. Let me know if there is anything else that could prevent this change from getting pulled.

Thanks for doing that! Let me start the workflows and see where we're at.

[miaulalala]

Looking good! Last commit is missing the signoff, you can add it with

git commit --amend --signoff and then
git push --force-with-lease

[miaulalala]

hey @Roszakos - please fix the unit tests:

 
Time: 01:36.992, Memory: 321.00 MB

There were 3 failures:

1) OCA\DAV\Tests\unit\CapabilitiesTest::testGetCapabilities
Failed asserting that two arrays are identical.
--- Expected
+++ Actual
@@ @@
     'dav' => Array &1 [
         'chunking' => '1.0',
         'public_shares_chunking' => true,
+        'search_supports_creation_time' => true,
+        'search_supports_upload_time' => true,
     ],
 ]

/home/runner/actions-runner/_work/server/server/apps/dav/tests/unit/CapabilitiesTest.php:36

2) OCA\DAV\Tests\unit\CapabilitiesTest::testGetCapabilitiesWithBulkUpload
Failed asserting that two arrays are identical.
--- Expected
+++ Actual
@@ @@
     'dav' => Array &1 [
         'chunking' => '1.0',
         'public_shares_chunking' => true,
+        'search_supports_creation_time' => true,
+        'search_supports_upload_time' => true,
         'bulkupload' => '1.0',
     ],
 ]

/home/runner/actions-runner/_work/server/server/apps/dav/tests/unit/CapabilitiesTest.php:57

3) OCA\DAV\Tests\unit\CapabilitiesTest::testGetCapabilitiesWithAbsence
Failed asserting that two arrays are identical.
--- Expected
+++ Actual
@@ @@
     'dav' => Array &1 [
         'chunking' => '1.0',
         'public_shares_chunking' => true,
+        'search_supports_creation_time' => true,
+        'search_supports_upload_time' => true,
         'absence-supported' => true,
         'absence-replacement' => true,
     ],
 ]

/home/runner/actions-runner/_work/server/server/apps/dav/tests/unit/CapabilitiesTest.php:79

If you need any help, join us in the community dev chat

[miaulalala]

Can you squash your commits into one?

First, sync your fork.

Then run git reset --soft origin/master

Commit all files git commit -sm "feat (2fa): Add IStatelessProvider interface"

And then push git push --force-with-lease

[Roszakos]

It's done

[Furgas]

Are you planning to include this PR in v34?

[miaulalala]

@Roszakos can you fix the CI issues please?

Psalm:

Error: lib/private/Talk/Broker.php:99:2: MissingOverrideAttribute: Method OC\Talk\Broker::isallowedtocreateconversations should have the "Override" attribute (see https://psalm.dev/358)
Error: lib/private/Talk/Broker.php:107:2: MissingOverrideAttribute: Method OC\Talk\Broker::isenabledforuser should have the "Override" attribute (see https://psalm.dev/358)

[provokateurin]

@miaulalala psalm was unrelated to the changes.

[Roszakos]

I squashed the last merge commit.
@provokateurin Could you please enable auto-merge again?

[Roszakos]

Some checks are still failing so i guess the auto-merge won't run (correct me if i'm wrong) - is there anything I should do about it?

[provokateurin]

I just restarted them. The failures are likely not related.

[welcome]

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22