fix(dashboard): remove duplicated IDs on the dashboard page#40768
Merged
Conversation
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
10 tasks
JuliaKirschenheuter
approved these changes
Oct 4, 2023
susnux
approved these changes
Oct 4, 2023
susnux
left a comment
susnux
left a comment
Contributor
There was a problem hiding this comment.
wild ID naming, but makes sense 👍
Contributor
Author
not the work of my hands ༼ つ ◕_◕ ༽つ |
Contributor
Author
|
Failed dron test is unrelated, I don't have rights to restart |
Contributor
|
Drone unrelated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dashboard used the same ID for header icons in every panel (dashboard widget).
This PR makes them unequal by using panel id as a part of ID
TODO
Checklist