Show loading icon in 'save share' button when creating a share#40752
Merged
Conversation
julien-nc
requested review from
a team,
nfebe,
skjnldsv and
susnux
and removed request for
a team
skjnldsv
approved these changes
Oct 3, 2023
Contributor
|
/compile amend |
susnux
added
4. to release
nextcloud-command
force-pushed
the
enh/40654/share-creation-loading-feedback
branch
from
3ae303d to
7bbdd37
Compare
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
julien-nc
force-pushed
the
enh/40654/share-creation-loading-feedback
branch
from
7bbdd37 to
4b11096
Compare
Member
Author
|
Thanks for the review 💙 Rebased on master and pushed compiled assets. Can this be backported to 27 which is also affected? |
Member
Author
|
/compile amend |
Signed-off-by: Julien Veyssier <julien-nc@posteo.net> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
nextcloud-command
force-pushed
the
enh/40654/share-creation-loading-feedback
branch
from
4b11096 to
217a2a1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #40654
This is a naive/simple solution to let users know something is happening when they click "save share" in the sharing tab of the Files sidebar.
Maybe it can be done differently by hiding the share permissions (the SharingDetailsTab component) while creating so users can see the sharee NcSelect which has a loading spinner already.