Skip to content

chore(deps): remove @nextcloud/vue-dashboard#40748

Merged
skjnldsv merged 1 commit into
masterfrom
chore/remove-nextcloud-vue-dashboard
Oct 3, 2023
Merged

chore(deps): remove @nextcloud/vue-dashboard#40748
skjnldsv merged 1 commit into
masterfrom
chore/remove-nextcloud-vue-dashboard

Conversation

@ShGKme

@ShGKme ShGKme commented Oct 2, 2023

Copy link
Copy Markdown
Contributor

Summary

@nextcloud/vue-dashboard is deprecated and actually not used in server anymore.
But it has some dependencies, including a very old @nextcloud/vue@3.

Removed 🧹

No dist changes after build.

TODO

  • Uninstall @nextcloud/vue-dashboard
  • Remove the only @nextcloud/vue-dashboard mention - in the webpack config

Checklist

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme added 3. to review Waiting for reviews technical debt 🧱 🤔🚀 labels Oct 2, 2023
@ShGKme ShGKme requested review from skjnldsv, susnux and szaimen October 2, 2023 17:12
@ShGKme ShGKme self-assigned this Oct 2, 2023
@ShGKme

ShGKme commented Oct 2, 2023

Copy link
Copy Markdown
Contributor Author

Drone error unrelated

@szaimen szaimen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Explanation makes sense but didnt test

@skjnldsv skjnldsv merged commit bdf1bfb into master Oct 3, 2023
@skjnldsv skjnldsv deleted the chore/remove-nextcloud-vue-dashboard branch October 3, 2023 08:23
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 3, 2023
@skjnldsv skjnldsv modified the milestones: Nextcloud 29, Nextcloud 28 Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4. to release Ready to be released and/or waiting for tests to finish technical debt 🧱 🤔🚀

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants