Fix/dashboard api#837
Merged
Merged
Conversation
provokateurin
force-pushed
the
fix/dashboard-api
branch
from
0cc22be to
1642067
Compare
Leptopoda
approved these changes
Sep 23, 2023
Member
Author
|
I will wait for nextcloud/server#40575 to be merged, otherwise it gets messy with depending on a commit that is not in the master branch. |
Signed-off-by: jld3103 <jld3103yt@gmail.com>
provokateurin
force-pushed
the
fix/dashboard-api
branch
from
1642067 to
1934f5a
Compare
Signed-off-by: jld3103 <jld3103yt@gmail.com>
provokateurin
force-pushed
the
fix/dashboard-api
branch
from
1934f5a to
9f10d78
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While writing dashboard tests I found that the specification was broken: nextcloud/server#40511 After updating that I wanted to regenerate everything, but then I hit nextcloud/server#40575 which I fixed as well, but then I also hit #759 again.