Media queue and Picture-in-Picture support#4032
Conversation
Signed-off-by: Serhii Kaliberda <169338670+s-kaliberda@users.noreply.github.com>
|
Hi @s-kaliberda, we will update you soon. |
|
Hi @s-kaliberda, would you mind writing an overview of how this implementation works, as well as what would be good to test. |
|
Hi. PiP doesn't work on iPhone simulator, use physical device or iPad simulator. |
Signed-off-by: Serhii Kaliberda <169338670+s-kaliberda@users.noreply.github.com>
|
@mpivchev I made a new commit with fixes to some bugs we found during our testing, please, pull the latest changes. |
|
Thanks! Some things I noticed:
I will continue testing. |
|
First test - when go back the video continue in background - I strongly recommend waiting for our refactoring of Viewer. |
|
Hi 👋 As @marinofaggiana mentioned earlier, we have a rewrite of the viewer component in the app: #4118 Please review it and check if all features you need are there, and if not, you can rebase and implement the additional features from this PR. Please let us know if you need any help :) |

Hi team,
After discussing media queue and Picture-in-Picture in the pull request, we agreed to use two libraries for media playback so that Picture-in-Picture will work. The media player uses AVKit for videos when the format is supported; otherwise, it uses MobileVLCKit.
This approach allowed us to preserve all existing functionality while also adding new features, such as a media queue for audio files and Picture-in-Picture for video files.
We implemented this logic in this pull request, and we’d like to hear your opinion on the implementation. Could you review the code and share your feedback?