Repository navigation
build(appstore): exclude development files from the app package - #452
Merged
Merged
Conversation
The release tarball shipped the CI workflows, Transifex config, agent instructions and the ESLint and Vitest configs. Move the package exclusions to .nextcloudignore, the file krankerl reads, and let the Makefile's rsync use it via --exclude-from so both packaging paths share one list. Assisted-by: Claude Code:claude-opus-5-5 Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
Member
Author
|
/backport to stable-0.1 |
3 tasks done
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 0.1.5-beta.3 tarball (and every release before it) ships files that are only used for development:
.github/(CI workflows, Dependabot config),.tx/,.l10nignore,AGENTS.md,CLAUDE.md,eslint.config.jsandvitest.config.ts.Changes:
.nextcloudignorewith the package exclusions, following what other Nextcloud apps keep there.make appstorenow usesrsync --exclude-from=.nextcloudignoreinstead of its inline--excludelist. The release workflow packages withmake appstorebecause the app has nokrankerl.toml, so.nextcloudignorealone would have no effect. With this change, both packaging paths read the same list.All previous exclusions are kept.
LICENSES/,REUSE.toml,vendor/(the editor's runtime libraries) and the source maps stay in the package.Tested with
make appstorein WSL. The package now has onlyAUTHORS.md,CHANGELOG.md,LICENSE,LICENSES/,REUSE.toml,appinfo/,img/,js/,l10n/,lib/,screenshots/,templates/andvendor/at the top level, with no dotfiles outsidevendor/apart froml10n/.gitkeep.🤖 AI (if applicable)