Repository navigation
fix(viewer): say when changes to a mind map are not saved - #422
Merged
Merged
Conversation
FreeMind and XMind files can be opened and edited, but not saved. The editor hid the save controls and closed without asking, so users lost their edits without being told. Show a notice when such a file opens. Refs #166 Assisted-by: Claude Code:claude-opus-5-5 Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
AndyScherzinger
added
bug
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #166
FreeMind (
.mm) and XMind files open in the editor and can be edited, but cannot be saved. For these formats the editor hides the save button and the autosave checkbox, and it closes without asking about unsaved changes, so users only find out their edits are gone when they open the file again (see the comments on #166).When a file in such a format opens,
FilesMindMap.load()now shows the toast "Changes to {extension} files are not saved." for 10 seconds. This PR does not add saving in.mmformat, which is the actual feature request in #166, so it only refers to the issue instead of closing it.Tested: added a check to the existing Vitest case for read-only formats that the toast is shown. Vitest and ESLint pass. I have not yet tested it in a running Nextcloud. The new string will be translated through Transifex.
A backport to
stable-0.1follows.🤖 AI (if applicable)