Repository navigation
feat: return structured import errors - #3538
Open
TheTisiboth wants to merge 1 commit into
Open
TheTisiboth wants to merge 1 commit into
TheTisiboth wants to merge 1 commit into
Conversation
Import failures return {msg, step}, unexpected errors a generic 500, and error responses no longer leak file/line. Frontend and API docs follow the new format.
Assisted-by: Claude Code:claude-opus-5-5
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Signed-off-by: Léo Jan <leo.jan@doctolib.com>
4 tasks done
Contributor
|
This PR/issue depends on:
|
Contributor
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #3279
Depends on #3510 (stacked).
Topic and Scope
Gives users a clear reason when an import fails.
400with{msg, step}(download,parse_html,extract_recipe); missing recipe name included500with a generic message (details only in the log)file/line(import,create,update)msgfor all 4xx import errorsConcerns/issues
API change: clients parsing the plain-string
400body of a failed import need to readmsg.Formal requirements
AI disclosure: prepared with Claude Code (claude-opus-5-5); reviewed by the author.
🤖 Generated with Claude Code