Skip to content

ci: cache test fixtures between runs #3537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TheTisiboth wants to merge 12 commits into
base: master
Choose a base branch
from
Open

ci: cache test fixtures between runs #3537

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
2682c99
ci: split test run into per-suite steps
TheTisiboth Oct 29, 2026
9ebcea5
ci: cache test fixtures between runs
TheTisiboth Oct 29, 2026
c03ba4d
ci: compute fixture cache key before the tests run
TheTisiboth Oct 29, 2026
8af37fb
ci: ignore Python bytecode in the fixture cache key
TheTisiboth Oct 29, 2026
fa8919c
ci: create mount folders before restoring a cached fixture
TheTisiboth Oct 29, 2026
fbdeef9
ci: wait for the final MySQL server in the healthcheck
TheTisiboth Oct 29, 2026
db5d4fe
ci: cache fixtures as a root tarball to include pgsql
TheTisiboth Oct 29, 2026
97bf3fe
Merge remote-tracking branch 'origin/master' into ci/cache-fixtures
TheTisiboth Oct 29, 2026
2f4d3e2
ci: include DB images in fixture cache key
TheTisiboth Oct 29, 2026
1d1081b
ci: reuse older fixtures on PRs when NC branch moved
TheTisiboth Oct 30, 2026
5882ba6
ci: scope fixture fallback to NC branch and current week
TheTisiboth Oct 30, 2026
6d53d36
ci: hash DB env files and key fixtures by cloned server SHA
TheTisiboth Oct 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/actions/run-tests/mysql/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ RUN apt-get update >/dev/null && \
apt-get clean

HEALTHCHECK --interval=1s --timeout=1s --retries=24 \
CMD mysqladmin ping --silent --socket /run/mysqld/mysqld.sock -ppass_root
CMD mysqladmin ping --silent -h 127.0.0.1 -ppass_root

COPY docker-entrypoint.sh /usr/local/bin
# CMD ["eatmydata", "mysqld"]
46 changes: 45 additions & 1 deletion .github/workflows/tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,19 +210,63 @@ jobs:
--http-server ${{ matrix.httpServer }}
--php-version ${{ matrix.phpVersion }}

- name: Compute the fixture cache key
id: fixtureKey
env:
FILES_HASH: ${{ hashFiles('lib/Migration/**', 'appinfo/info.xml', '.github/actions/run-tests/*.py', '.github/actions/run-tests/docker-compose.yml', '.github/actions/run-tests/*.env', '.github/actions/run-tests/mysql/**', '.github/actions/run-tests/postgres/**', '.github/actions/run-tests/test_runner/*.py', '.github/actions/run-tests/scripts/**', '.github/actions/run-tests/tests/**') }}
run: >-
sha="$(git ls-remote https://github.com/nextcloud/server refs/heads/stable${{ matrix.coreVersion }} | cut -f1)" &&
prefix="fixture-tar-${{ matrix.database }}-${{ matrix.coreVersion }}-${{ matrix.phpVersion }}-$FILES_HASH-$(date -u +%G-%V)-" &&
echo "prefix=$prefix" >> "$GITHUB_OUTPUT" &&
echo "key=$prefix$sha" >> "$GITHUB_OUTPUT"
Comment thread
coderabbitai[bot] marked this conversation as resolved.

- name: Restore the cached fixtures
id: fixtureCache
uses: actions/cache/restore@55cc8345863c7cc4c66a329aec7e433d2d1c52a9
with:
path: ${{ runner.temp }}/fixture.tar
key: ${{ steps.fixtureKey.outputs.key }}
restore-keys: ${{ steps.fixtureKey.outputs.prefix }}

- name: Check if the cached fixtures can be used
id: fixtureHit
run: >-
echo "hit=${{ steps.fixtureCache.outputs.cache-hit == 'true' || (github.event_name == 'pull_request' && steps.fixtureCache.outputs.cache-matched-key != '') }}" >> "$GITHUB_OUTPUT"
Comment thread
coderabbitai[bot] marked this conversation as resolved.

- name: Extract the cached fixtures
if: steps.fixtureHit.outputs.hit == 'true'
run: >-
mkdir -p .github/actions/run-tests/volumes/dumps &&
sudo tar -xpf "$RUNNER_TEMP/fixture.tar" -C .github/actions/run-tests/volumes/dumps

- name: Create the fixtures for the tests
id: fixtures
run: >-
if [ "${{matrix.database}}" = 'pgsql' ]; then PARAM=''; else PARAM='--use-db-dump'; fi &&
cd .github/actions/run-tests &&
if [ "${{ steps.fixtureHit.outputs.hit }}" = 'true' ]; then mkdir -p volumes/nextcloud/custom_apps/cookbook volumes/nextcloud/data && PARAM='--start-helpers'; else PARAM="$PARAM --create-fixture default stable${{ matrix.coreVersion }}"; fi &&
./run-locally.py
$PARAM
--create-fixture default stable${{ matrix.coreVersion }}
--activate-fixture default
--input-db ${{ matrix.database }}
--http-server ${{ matrix.httpServer }}
--php-version ${{ matrix.phpVersion }}

- name: Archive the fixtures
id: fixtureArchive
if: steps.fixtureHit.outputs.hit != 'true'
run: >-
echo "key=${{ steps.fixtureKey.outputs.prefix }}$(git -c safe.directory="*" -C .github/actions/run-tests/volumes/nextcloud rev-parse HEAD)" >> "$GITHUB_OUTPUT" &&
sudo tar -cf "$RUNNER_TEMP/fixture.tar" -C .github/actions/run-tests/volumes/dumps version.json fixtures/default &&
sudo chown "$USER" "$RUNNER_TEMP/fixture.tar"

- name: Cache the fixtures
if: steps.fixtureHit.outputs.hit != 'true'
uses: actions/cache/save@55cc8345863c7cc4c66a329aec7e433d2d1c52a9
Comment thread
TheTisiboth marked this conversation as resolved.
with:
path: ${{ runner.temp }}/fixture.tar
key: ${{ steps.fixtureArchive.outputs.key }}

- name: Run the unit tests
if: ${{ !cancelled() && steps.fixtures.outcome == 'success' }}
run: >-
Expand Down
Loading