fix: adjust supported php versions#5383
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
DerDreschner
approved these changes
Jun 15, 2026
ChristophWurst
left a comment
ChristophWurst
left a comment
Member
There was a problem hiding this comment.
33 is 8.2+ 👍
Nit: this is not a chore change. You are effectively changing the product and what it supports. Per https://docs.nextcloud.com/server/latest/developer_manual/app_publishing_maintenance/release_process.html#minor-updates this will need a minor version bump.
hamza221
force-pushed
the
chore/php-versions
branch
from
0e18a74 to
5f9e086
Compare
hamza221
changed the title
Signed-off-by: Hamza <hamzamahjoubi221@gmail.com>
hamza221
force-pushed
the
chore/php-versions
branch
from
5f9e086 to
3b037ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.