fix(teams): restore selectedGroup on circle/user_group routes to fix "Unable to create contact" error (#5257)#5377
Conversation
hamza221
left a comment
There was a problem hiding this comment.
Hello,
Same for this PR please run npm ci then npm run lint:fix then push again.
DCO is also failing please also run:
- In your local branch, run: git rebase HEAD~1 --signoff
- Force push your changes to overwrite the branch: git push --force-with-lease origin [branch]
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
…"Unable to create contact" error (nextcloud#5257) Signed-off-by: pallavibakale <pallavibakale09@gmail.com>
d5a2c09 to
e0519ce
Compare
Hello Hamza, the linting issue is fixed and DCO is passed. Thanks! |
Signed-off-by: pallavibakale <pallavibakale09@gmail.com>
Signe-off-by: pallavibakale <pallavibakale09@gmail.com> Signed-off-by: pallavibakale <pallavibakale09@gmail.com>
e0519ce to
ff7df94
Compare
Signed-off-by: pallavibakale <pallavibakale09@gmail.com>
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
fix(teams): fix "Unable to create contact" error when a team is selected
RouterMixin.selectedGroup read only from
$route.params.selectedGroup, which is absent on circle and user_group routes after a routing refactor that moved them to dedicated paths. This caused selectedGroup to be undefined on team routes, breaking isCirclesView (always false) and making newContact() fall through to a router.push with a missing required param.Fix RouterMixin to derive selectedGroup from the route name when the param is absent. Update newContact() to check selectedCircle directly for the circle-specific event, extend the group-exclusion list to cover
ROUTE_CIRCLEandROUTE_USER_GROUP, and fall back toGROUP_ALL_CONTACTSwhen navigating from a user group view.Fixes #5257