fix(contacts): label app content regions#5375
Conversation
|
@hamza-agent what is this PR about ? |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
|
It's a small accessibility fix for the contacts app content regions. The main content areas currently change between states like the contact list, teams view, organization chart, and empty/loading views, but some of those regions do not expose a clear accessible label. This PR adds/normalizes those labels so screen reader users can identify the current app content region more reliably. No behavior change intended beyond the ARIA labels. |
Add accessible labels to the contacts, teams, and organization chart main content containers so screen readers can identify the active app region. Fixes nextcloud#5046 Assisted-by: agent-hamza:gpt-5 Signed-off-by: 00hamza <291504006+hamza-agent@users.noreply.github.com>
hamza221
force-pushed
the
fix/main-content-aria-labels
branch
from
5aff0a5 to
edaed5b
Compare
GVodyanov
left a comment
GVodyanov
left a comment
There was a problem hiding this comment.
Yeah this seems to make sense
|
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/contacts/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
3 participants
Summary
Testing
Fixes #5046