fix: allow custom URL input for Seafile remotes (and others where relevant)#390
Open
ivanskodje wants to merge 1 commit into
Open
fix: allow custom URL input for Seafile remotes (and others where relevant)#390ivanskodje wants to merge 1 commit into
ivanskodje wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #380
Problem
Editable dropdown fields are hardcoded to
false! This means in order to add and use our own self-hosted seafile data, we need hacky solutions, like manually editing conf files.Solution
Make it conditional based on rclone's
exclusivemetadata flag, which indicates whether or not custom values are allowed.The app should already parse this flag from the rclone config providers JSON into
ProviderOption.exclusiveSince Seafile's URL option does not set
Exclusive: truein rclone's source, custom URLs will now be permitted.Example of how to verifying the rclone config Seafile uses (Debian/Ubuntu)
Note there's no
Exclusivefield (defaults tofalse):{ "Name": "url", "Help": "URL of seafile host to connect to", "Provider": "", "Default": "", "Value": null, "Examples": [ { "Value": "https://cloud.seafile.com/", "Help": "Connect to cloud.seafile.com", "Provider": "" } ], "ShortOpt": "", "Hide": 0, "Required": true, "IsPassword": false, "NoPrefix": false, "Advanced": false, "DefaultStr": "", "ValueStr": "", "Type": "string" }You can also verify that we parse this
Exclusivefield inProviderOption.ktand set it toitem.exclusive.Testing / Verify
Add a new Seafile remote and verify that: