Table map and error event improvements#24
Open
jmealo wants to merge 9 commits into
Open
Conversation
Contributor
Author
There was a problem hiding this comment.
This is how a DBA taught me to format SQL for readability, it's opinionated so I'm fine with just truncating it at 80 characters onto however many lines if that makes everyone happy.
It seemed like a good idea to get rid of the extra spaces once rather than sending them over with every query. If the join bothers anyone it can be converted to a string, it's only going to run once so performance shouldn't be a concern.
…red while trying to read the information_schema
… flags to each column.
…tive MySQL timezone
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improvements:
ctrlConnectionerrors and unhandledErrors will be relayed by Zongjiconstraints(null or object) andnullable(boolean) properties.For discussion
typerather than the code. Will this break anything internally?Given the following DDL:
Your table map columns would look like this: