fix(php-cs-fixer): switch @PSR12 → @PER-CS and bump migration preset to @PHP84Migration

.php-cs-fixer.dist.php

@@ -25,10 +25,13 @@
     ->setRiskyAllowed(true)
     ->setRules([
         // Presets
-        '@PSR12' => true,
-        '@PSR12:risky' => true,
-        '@PHP83Migration' => true,
-        '@PHP80Migration:risky' => true,
+        '@PER-CS' => true,
+        '@PER-CS:risky' => true,
+        '@PHP84Migration' => true,
+        // PHP-CS-Fixer 3.95 has no @PHP83Migration:risky or @PHP84Migration:risky;
+        // @PHP82Migration:risky is the latest extant risky migration set and a strict
+        // superset of @PHP80Migration:risky (the previous setting).
+        '@PHP82Migration:risky' => true,
         '@Symfony' => true,
         '@Symfony:risky' => true,
 

tests/Command/TtSyncSubticketsCommandTest.php

@@ -49,8 +49,8 @@ public function testRunsForAllProjectsWithTicketSystem(): void
             ->willReturnOnConsecutiveCalls(['X-1', 'X-2'], []);
 
         // Repository mock that returns a minimal query builder-like object
-        $project = (new Project())->setId(1)->setName('Alpha');
-        $p2 = (new Project())->setId(2)->setName('Beta');
+        $project = new Project()->setId(1)->setName('Alpha');
+        $p2 = new Project()->setId(2)->setName('Beta');
         $projectRepo = $this->getMockBuilder(\Doctrine\ORM\EntityRepository::class)
             ->disableOriginalConstructor()
             ->onlyMethods(['createQueryBuilder'])

tests/Controller/ControllingControllerTest.php

@@ -123,11 +123,11 @@ public function testExportActionWithBillableAndTicketTitles(): void
         $exportServiceMock = $this->createMock(Export::class);
 
         // --- Real entities for export ---
-        $user = (new \App\Entity\User())->setId(1)->setUsername('unittest');
-        $customer = (new \App\Entity\Customer())->setId(1)->setName('Test Customer');
-        $project = (new \App\Entity\Project())->setId(1)->setName('Test Project');
+        $user = new \App\Entity\User()->setId(1)->setUsername('unittest');
+        $customer = new \App\Entity\Customer()->setId(1)->setName('Test Customer');
+        $project = new \App\Entity\Project()->setId(1)->setName('Test Project');
 
-        $entry1 = (new \App\Entity\Entry())
+        $entry1 = new \App\Entity\Entry()
             ->setId(4)
             ->setDay(new DateTime('2023-10-15'))
             ->setStart(new DateTime('2023-10-15 09:00:00'))
@@ -139,7 +139,7 @@ public function testExportActionWithBillableAndTicketTitles(): void
             ->setDescription('Real Desc 1');
         // ->setActivity(null) // Assuming default is fine or set if needed
 
-        $entry2 = (new \App\Entity\Entry())
+        $entry2 = new \App\Entity\Entry()
             ->setId(5)
             ->setDay(new DateTime('2023-10-20'))
             ->setStart(new DateTime('2023-10-20 11:00:00'))
@@ -233,11 +233,11 @@ public function testExportActionHidesBillableFieldWhenNotConfigured(): void
         $exportServiceMock = $this->createMock(Export::class);
 
         // --- Mock data for export ---
-        $user = (new \App\Entity\User())->setId(1)->setUsername('testuser');
-        $customer = (new \App\Entity\Customer())->setId(1)->setName('Test Customer');
-        $project = (new \App\Entity\Project())->setId(1)->setName('Test Project');
+        $user = new \App\Entity\User()->setId(1)->setUsername('testuser');
+        $customer = new \App\Entity\Customer()->setId(1)->setName('Test Customer');
+        $project = new \App\Entity\Project()->setId(1)->setName('Test Project');
 
-        $entry1 = (new \App\Entity\Entry())
+        $entry1 = new \App\Entity\Entry()
             ->setId(6)
             ->setDay(new DateTime('2023-11-05'))
             ->setStart(new DateTime('2023-11-05 08:00:00'))

tests/Performance/PerformanceBenchmarkRunner.php

@@ -80,7 +80,7 @@ private function setupRegressionThresholds(): void
     public function runAllBenchmarks(): array
     {
         $this->benchmarkResults = [
-            'timestamp' => (new DateTime())->format('c'),
+            'timestamp' => new DateTime()->format('c'),
             'php_version' => PHP_VERSION,
             'memory_limit' => ini_get('memory_limit'),
             'max_execution_time' => ini_get('max_execution_time'),
@@ -213,7 +213,7 @@ private function runSingleBenchmark(string $testClass, string $method): array
             'execution_time_ms' => round(($endTime - $startTime) * 1000, 2),
             'memory_usage_bytes' => $endMemory - $startMemory,
             'peak_memory_usage_bytes' => $endPeakMemory - $startPeakMemory,
-            'timestamp' => (new DateTime())->format('c'),
+            'timestamp' => new DateTime()->format('c'),
         ];
     }
 

tests/Performance/PerformanceDashboard.php

@@ -455,7 +455,7 @@ private function prepareChartData(array $history): array
             if (!is_string($runTimestamp)) {
                 $runTimestamp = is_scalar($runTimestamp) ? (string) $runTimestamp : date('c');
             }
-            $timestamps[] = (new DateTime($runTimestamp))->format('M d');
+            $timestamps[] = new DateTime($runTimestamp)->format('M d');
 
             // Calculate average execution time per run
             $totalTime = 0;

tests/Repository/EntryRepositoryTest.php

@@ -40,8 +40,8 @@ public function today(): DateTimeImmutable
         };
 
         // Avoid touching Doctrine by creating a partial instance without constructor
-        $entryRepository = (new ReflectionClass(EntryRepository::class))->newInstanceWithoutConstructor();
-        $reflectionProperty = (new ReflectionClass(EntryRepository::class))->getProperty('clock');
+        $entryRepository = new ReflectionClass(EntryRepository::class)->newInstanceWithoutConstructor();
+        $reflectionProperty = new ReflectionClass(EntryRepository::class)->getProperty('clock');
         $reflectionProperty->setValue($entryRepository, $clock);
 
         // 1 working day on Monday should include previous Fri,Sat,Sun => 3 calendar days
@@ -65,9 +65,9 @@ public function today(): DateTimeImmutable
             } // Tuesday
         };
         // Avoid touching Doctrine by creating a partial mock that bypasses parent constructor
-        $entryRepository = (new ReflectionClass(EntryRepository::class))->newInstanceWithoutConstructor();
+        $entryRepository = new ReflectionClass(EntryRepository::class)->newInstanceWithoutConstructor();
         // Inject clock via reflection
-        $reflectionProperty = (new ReflectionClass(EntryRepository::class))->getProperty('clock');
+        $reflectionProperty = new ReflectionClass(EntryRepository::class)->getProperty('clock');
         $reflectionProperty->setValue($entryRepository, $clock);
 
         self::assertSame(0, $entryRepository->getCalendarDaysByWorkDays(0));
@@ -89,8 +89,8 @@ public function today(): DateTimeImmutable
             } // Monday
         };
         // Avoid touching Doctrine by creating a partial mock that bypasses parent constructor
-        $entryRepository = (new ReflectionClass(EntryRepository::class))->newInstanceWithoutConstructor();
-        $reflectionProperty = (new ReflectionClass(EntryRepository::class))->getProperty('clock');
+        $entryRepository = new ReflectionClass(EntryRepository::class)->newInstanceWithoutConstructor();
+        $reflectionProperty = new ReflectionClass(EntryRepository::class)->getProperty('clock');
         $reflectionProperty->setValue($entryRepository, $clock);
 
         self::assertSame(3, $entryRepository->getCalendarDaysByWorkDays(1)); // Monday spans back to Friday
@@ -110,8 +110,8 @@ public function today(): DateTimeImmutable
             }
         };
 
-        $entryRepository = (new ReflectionClass(EntryRepository::class))->newInstanceWithoutConstructor();
-        $reflectionProperty = (new ReflectionClass(EntryRepository::class))->getProperty('clock');
+        $entryRepository = new ReflectionClass(EntryRepository::class)->newInstanceWithoutConstructor();
+        $reflectionProperty = new ReflectionClass(EntryRepository::class)->getProperty('clock');
         $reflectionProperty->setValue($entryRepository, $clock);
 
         self::assertSame(0, $entryRepository->getCalendarDaysByWorkDays(-5));
@@ -132,8 +132,8 @@ public function today(): DateTimeImmutable
             } // Friday
         };
 
-        $entryRepository = (new ReflectionClass(EntryRepository::class))->newInstanceWithoutConstructor();
-        $reflectionProperty = (new ReflectionClass(EntryRepository::class))->getProperty('clock');
+        $entryRepository = new ReflectionClass(EntryRepository::class)->newInstanceWithoutConstructor();
+        $reflectionProperty = new ReflectionClass(EntryRepository::class)->getProperty('clock');
         $reflectionProperty->setValue($entryRepository, $clock);
 
         // 1 working day on Friday should be just 1 calendar day
@@ -158,8 +158,8 @@ public function today(): DateTimeImmutable
             } // Wednesday
         };
 
-        $entryRepository = (new ReflectionClass(EntryRepository::class))->newInstanceWithoutConstructor();
-        $reflectionProperty = (new ReflectionClass(EntryRepository::class))->getProperty('clock');
+        $entryRepository = new ReflectionClass(EntryRepository::class)->newInstanceWithoutConstructor();
+        $reflectionProperty = new ReflectionClass(EntryRepository::class)->getProperty('clock');
         $reflectionProperty->setValue($entryRepository, $clock);
 
         // 1 working day on Wednesday is just 1 calendar day

tests/Repository/EntryRepositoryUnitTest.php

@@ -24,7 +24,7 @@ final class EntryRepositoryUnitTest extends TestCase
      */
     private function createRepositoryWithClock(ClockInterface $clock): EntryRepository
     {
-        $repository = (new ReflectionClass(EntryRepository::class))->newInstanceWithoutConstructor();
+        $repository = new ReflectionClass(EntryRepository::class)->newInstanceWithoutConstructor();
 
         // Use reflection to set the readonly property before it's initialized
         $reflectionClass = new ReflectionClass(EntryRepository::class);

tests/Security/LdapAuthenticatorTest.php

@@ -198,7 +198,7 @@ public function testAuthenticateReturnsExistingUser(): void
     {
         $this->configureDefaultLdapParams();
 
-        $existingUser = (new User())->setUsername('testuser');
+        $existingUser = new User()->setUsername('testuser');
 
         $userRepo = $this->createMock(UserRepository::class);
         $userRepo->method('findOneBy')->willReturn($existingUser);
@@ -278,7 +278,7 @@ public function testAuthenticateCreatesUserWithTeams(): void
     {
         $this->configureDefaultLdapParams();
 
-        $team = (new Team())->setName('Dev Team');
+        $team = new Team()->setName('Dev Team');
 
         $userRepo = $this->createMock(UserRepository::class);
         $userRepo->method('findOneBy')->willReturn(null);
@@ -584,7 +584,7 @@ public function testAuthenticateWithValidEmailUsername(): void
     {
         $this->configureDefaultLdapParams();
 
-        $existingUser = (new User())->setUsername('user@example.com');
+        $existingUser = new User()->setUsername('user@example.com');
 
         $userRepo = $this->createMock(UserRepository::class);
         $userRepo->method('findOneBy')->willReturn($existingUser);