Skip to content

Minor security hardening#1589

Open
jotak wants to merge 1 commit into
netobserv:mainfrom
jotak:hardening
Open

Minor security hardening#1589
jotak wants to merge 1 commit into
netobserv:mainfrom
jotak:hardening

Conversation

@jotak

@jotak jotak commented Jun 26, 2026

Copy link
Copy Markdown
Member

Description

  • sha pinning of the remaining github-owned actions
  • dependabot setting for docker & actions
  • force tls client minversion

Dependencies

n/a

Checklist

  • Does the changes in PR need specific configuration or environment set up for testing?
    • if so please describe it in PR description.
  • I have added thorough unit tests for the change.
  • QE requirements (check 1 from the list):
    • Standard QE validation, with pre-merge tests unless stated otherwise.
    • Regression tests only (e.g. refactoring with no user-facing change).
    • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

- sha pinning of the remaining github-owned actions
- dependabot setting for docker & actions
- force tls client minversion
@jotak jotak requested review from leandroberetta and memodi June 26, 2026 07:38
@coderabbitai

coderabbitai Bot commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@jotak, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 47 minutes and 36 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 74260eeb-25fa-43e0-9154-788d187ba60d

📥 Commits

Reviewing files that changed from the base of the PR and between 8c99f38 and 2a576e6.

📒 Files selected for processing (7)
  • .github/dependabot.yml
  • .github/workflows/build_image_pr.yml
  • .github/workflows/pull_request.yml
  • .github/workflows/push_image.yml
  • .github/workflows/push_image_pr.yml
  • .github/workflows/release.yml
  • pkg/httpclient/http_client.go
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Jun 26, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign memodi for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jotak jotak added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jun 26, 2026
@github-actions

Copy link
Copy Markdown

New images:

quay.io/netobserv/network-observability-console-plugin:2a576e6c
quay.io/netobserv/network-observability-standalone-frontend:2a576e6c

They will expire in two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=2a576e6c make set-plugin-image

@openshift-ci

openshift-ci Bot commented Jun 26, 2026

Copy link
Copy Markdown

@jotak: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/integration-tests 2a576e6 link false /test integration-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test To set manually when a PR is safe to test. Triggers image build on PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant