Skip to content

NETOBSERV-123: test#1583

Closed
jotak wants to merge 1 commit into
netobserv:mainfrom
jotak:test
Closed

NETOBSERV-123: test#1583
jotak wants to merge 1 commit into
netobserv:mainfrom
jotak:test

Conversation

@jotak

@jotak jotak commented Jun 22, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Chores
    • Simplified pull request build workflow to automatically trigger image builds on labeled events without requiring additional label approval.

@openshift-ci

openshift-ci Bot commented Jun 22, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign memodi for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

Removes the job-level if: ${{ github.event.label.name == 'ok-to-test' }} condition from the build-pr-image job in .github/workflows/build_image_pr.yml, so the job now runs on any labeled pull request event regardless of label name.

Changes

CI Label Gate Removal

Layer / File(s) Summary
Remove ok-to-test label condition
.github/workflows/build_image_pr.yml
Deletes the single if guard on build-pr-image, making the job execute for all labeled PR events.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (1 warning, 1 inconclusive)

Check name Status Explanation Resolution
Description check ⚠️ Warning No pull request description was provided; all required template sections are missing. Add a complete description following the template, including what changed, why, dependencies, and QE requirements.
Title check ❓ Inconclusive The title 'NETOBSERV-123: test' is vague and generic, using 'test' which doesn't meaningfully convey what changed in the workflow. Replace 'test' with a descriptive summary of the actual change, such as 'Remove ok-to-test label requirement from build-pr-image job'.
✅ Passed checks (3 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

Review ran into problems

🔥 Problems

Linked repositories: Your configuration references 2 linked repositories, but your current plan allows 0. Analyzed ``, skipped netobserv/netobserv-operator, `netobserv/flowlogs-pipeline`.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@jotak jotak changed the title test NETOBSERV-123: test Jun 22, 2026
@openshift-ci-robot

openshift-ci-robot commented Jun 22, 2026

Copy link
Copy Markdown
Collaborator

@jotak: This pull request references NETOBSERV-123 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set.

Details

In response to this:

Summary by CodeRabbit

  • Chores
  • Simplified pull request build workflow to automatically trigger image builds on labeled events without requiring additional label approval.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@jotak jotak added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Jun 22, 2026
@github-actions

Copy link
Copy Markdown

New images:

quay.io/netobserv/network-observability-console-plugin:347ccae5
quay.io/netobserv/network-observability-standalone-frontend:347ccae5

They will expire in two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=347ccae5 make set-plugin-image

@jotak jotak closed this Jun 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference ok-to-test To set manually when a PR is safe to test. Triggers image build on PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants