NETOBSERV-2693 Open Flowcollector status page from OLM page

[jpinsonneau]

Description

• Open status page when clicking on FlowCollectur 'cluster' from OLM page & search page
• Add a delete button from status page
• Handle missing FC from status page by showing a message + create button

Dependencies

n/a

Checklist

• Does the changes in PR need specific configuration or environment set up for testing?
  • if so please describe it in PR description.
• I have added thorough unit tests for the change.
• QE requirements (check 1 from the list):
  • Standard QE validation, with pre-merge tests unless stated otherwise.
  • Regression tests only (e.g. refactoring with no user-facing change).
  • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Summary by CodeRabbit

Release Notes

• New Features

  • Added "Delete FlowCollector" action to the management UI
  • Added empty-state messaging to guide users in creating a FlowCollector
  • Added loading indicator while resource resolves

• Bug Fixes

  • Improved handling of missing FlowCollector resources
  • Fixed potential errors when resource models are temporarily unavailable

• Tests

  • Added coverage for resource not-found error scenarios

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 0a8e0b19-0aa4-4cb8-8cf0-6b1a3f226172

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[jpinsonneau]

/cherry-pick main

[openshift-cherrypick-robot]

@jpinsonneau: once the present PR merges, I will cherry-pick it on top of main in a new PR and assign it to you.

Details

In response to this:

/cherry-pick main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (1)

web/src/components/forms/resource-watcher.tsx (1)

154-154: 💤 Low value

Extract magic number to a named constant.

The 1000ms delay is a workaround for K8s watch behavior. A named constant improves clarity and makes it easier to tune later.

♻️ Suggested change

+const CR_MISSING_CONFIRMATION_DELAY_MS = 1000;
+
 export const ResourceWatcher: FC<ResourceWatcherProps> = ({

Then at line 154:

-    const timer = window.setTimeout(() => setMissingConfirmed(true), 1000);
+    const timer = window.setTimeout(() => setMissingConfirmed(true), CR_MISSING_CONFIRMATION_DELAY_MS);

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@web/src/components/forms/resource-watcher.tsx` at line 154, Replace the
hardcoded 1000ms value in the window.setTimeout call that sets
setMissingConfirmed(true) with a named constant. Define a constant at the module
level (near the top of the file) with a semantic name that reflects its purpose
as a K8s watch behavior workaround delay, then use that constant in place of the
magic number 1000 to improve code clarity and maintainability.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@web/locales/en/plugin__netobserv-plugin.json`:
- Line 223: Fix the spelling errors in the translation key and value that appear
in user-facing error messages. In web/locales/en/plugin__netobserv-plugin.json
at line 223, correct the key and value by changing "occured" to "occurred" and
"retreiving" to "retrieving" in both the key name and the string value. Then in
web/src/components/forms/flowCollector-status.tsx at line 180, update the t()
translation call to use the corrected translation key name that reflects the
fixed spelling.

---

Nitpick comments:
In `@web/src/components/forms/resource-watcher.tsx`:
- Line 154: Replace the hardcoded 1000ms value in the window.setTimeout call
that sets setMissingConfirmed(true) with a named constant. Define a constant at
the module level (near the top of the file) with a semantic name that reflects
its purpose as a K8s watch behavior workaround delay, then use that constant in
place of the magic number 1000 to improve code clarity and maintainability.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: c974798f-4b19-4faa-9f74-3d90408961b7

📥 Commits

Reviewing files that changed from the base of the PR and between a336c5b and 41bf6bb.

📒 Files selected for processing (9)

• web/locales/en/plugin__netobserv-plugin.json
• web/src/components/forms/flowCollector-status.tsx
• web/src/components/forms/flowCollector.tsx
• web/src/components/forms/resource-watcher.tsx
• web/src/components/forms/utils.ts
• web/src/components/status/__tests__/flowcollector-status.spec.tsx
• web/src/utils/k8s-models-hook.ts
• web/src/utils/url.ts
• web/webpack.config.ts

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign memodi for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• DOWNSTREAM_OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jpinsonneau]

Rebased without changes

[openshift-ci]

@jpinsonneau: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/integration-tests	869f117	link	false	/test integration-tests
ci/prow/pf5-integration-tests	7988018	link	false	/test pf5-integration-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.